From: Jani Nikula <jani@nikula.org>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/4] test: Add broken test for tag synchronization on
	files delivered to new/
In-Reply-To: <1338742656-11640-2-git-send-email-amdragon@mit.edu>
References: <1338742656-11640-1-git-send-email-amdragon@mit.edu>
	<1338742656-11640-2-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.13+9~ga1668d0 (http://notmuchmail.org) Emacs/23.1.1
	(i686-pc-linux-gnu)
Date: Mon, 04 Jun 2012 07:10:03 +0000
Message-ID: <87k3znr1ro.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Sun, 03 Jun 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> Currently, notmuch new only synchronizs maildir flags to tags for

+e to synchronizs.

> files that have an "info" part.  However, in maildir, new mail doesn't
> gain the info part until it moves from new/ to cur/.  Hence, even
> though mail in new/ doesn't have an info part, it is still a maildir
> message and thus has maildir flags (though none of them set).
>
> The most visible effect of not synchronizing maildir flags for
> messages in new/ is that newly delivered messages don't get the unread
> tag (unless it is assigned by some other mechanism, like new.tags).
>
> This patch does *not* modify the test for messages in cur/ that do not
> have an "info" part.  Unlike a message in new/, a message in cur/
> without an info part is no longer a maildir message, and thus
> shouldn't be subject to maildir flag synchronization.
> ---
>  test/maildir-sync |   10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/test/maildir-sync b/test/maildir-sync
> index d72ec07..6360fd2 100755
> --- a/test/maildir-sync
> +++ b/test/maildir-sync
> @@ -166,4 +166,14 @@ add_message [subject]='"Non-compliant maildir info"' [dir]=cur [filename]='non-c
>  notmuch tag +unread +draft -flagged subject:"Non-compliant maildir info"
>  test_expect_equal "$(cd $MAIL_DIR/cur/; ls non-compliant*)" "non-compliant-maildir-info:2,These-are-not-flags-in-ASCII-order-donottouch"
>  
> +test_begin_subtest "Files in new/ get default synchronized tags"
> +test_subtest_known_broken
> +OLDCONFIG=$(notmuch config get new.tags)
> +notmuch config set new.tags test
> +add_message [subject]='"File in new/"' [dir]=new [filename]='file-in-new'
> +notmuch config set new.tags $OLDCONFIG
> +notmuch search 'subject:"File in new"' | notmuch_search_sanitize > output
> +test_expect_equal "$(< output)" \
> +"thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; File in new/ (test unread)"
> +
>  test_done
> -- 
> 1.7.10
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch