Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0DB1C431FD0 for ; Thu, 24 Nov 2011 07:43:50 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rOpzhdVyLaWb for ; Thu, 24 Nov 2011 07:43:49 -0800 (PST) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id 2E02C431FB6 for ; Thu, 24 Nov 2011 07:43:49 -0800 (PST) Received: from localhost (unknown [192.168.200.4]) by max.feld.cvut.cz (Postfix) with ESMTP id 7A6CA3CFE73; Thu, 24 Nov 2011 16:43:48 +0100 (CET) X-Virus-Scanned: IMAP AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, port 10044) with ESMTP id 04nX+2nSBiBP; Thu, 24 Nov 2011 16:43:47 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id 7B75F3CFE71; Thu, 24 Nov 2011 16:43:47 +0100 (CET) Received: from steelpick.2x.cz (unknown [141.76.49.23]) (Authenticated sender: sojkam1) by imap.feld.cvut.cz (Postfix) with ESMTPSA id 1A47F660965; Thu, 24 Nov 2011 16:43:47 +0100 (CET) Received: from wsh by steelpick.2x.cz with local (Exim 4.76) (envelope-from ) id 1RTbSk-0006pL-SR; Thu, 24 Nov 2011 16:43:46 +0100 From: Michal Sojka To: Daniel Schoepe , David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello In-Reply-To: <8762i9aaci.fsf@schoepe.localhost> References: <87ippzysmv.fsf@steelpick.2x.cz> <1318253982-23588-1-git-send-email-daniel@schoepe.org> <1318253982-23588-2-git-send-email-daniel@schoepe.org> <87aa7l8w2d.fsf@zancas.localnet> <8762i9aaci.fsf@schoepe.localhost> User-Agent: Notmuch/0.8-40-g6eb7026 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Thu, 24 Nov 2011 16:43:46 +0100 Message-ID: <87aa7lle4t.fsf@steelpick.2x.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2011 15:43:50 -0000 On Thu, 24 Nov 2011, Daniel Schoepe wrote: > On Thu, 24 Nov 2011 09:54:50 -0400, David Bremner wrote: > > On Mon, 10 Oct 2011 15:39:41 +0200, Daniel Schoepe wrote: > > > From: Daniel Schoepe > > > > > > This patch makes the notmuch-hello screen fully customizable > > > by allowing the user to add and remove arbitrary sections. It > > > also provides some convenience functions for constructing sections, > > > e.g. showing the unread message count for each tag. > > > > > > > Yow, that is a big patch, I think it needs some more review. I use this patch on a daily basis. There is probably some space for improvements, especially in the coding style, but I'd like to see a more experience elisp hacker than me looking at it. > Yes; Unfortunately I didn't manage to come up with good partitioning > into smaller patches, because the changes are quite interconnected. > > Is there something I can do to help with the review? > > I think there's also one performance improvement written by Michal > Sojka, that isn't included in this version yet, Yes, that's true. I'm aware of one bug in this improvement. I usually start notmuch by emacsclient -c -a '' -e "(notmuch)" and the bug is that sometimes the emacs window disappear immediately after appearing. This did not happen without this improvement and I guess it is caused by some unexpected return value, perhaps in the code which determines the initial position of the point. Cheers, -Michal