Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AEE67429E5B for ; Sat, 15 Dec 2012 04:45:28 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KB5XKAcGX7NS for ; Sat, 15 Dec 2012 04:45:28 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 2E7D2431FC2 for ; Sat, 15 Dec 2012 04:45:28 -0800 (PST) Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net ([142.167.90.129] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Tjr7O-0006Bv-S4; Sat, 15 Dec 2012 08:45:27 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1Tjr7J-00007y-Ba; Sat, 15 Dec 2012 08:45:21 -0400 From: david@tethera.net To: notmuch@notmuchmail.org Subject: [Patch v3 01/11] perf-test: propagate non-zero returns from /usr/bin/time Date: Sat, 15 Dec 2012 08:45:04 -0400 Message-Id: <1355575514-32735-2-git-send-email-david@tethera.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1355575514-32735-1-git-send-email-david@tethera.net> References: <1355575514-32735-1-git-send-email-david@tethera.net> X-Spam_bar: - Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2012 12:45:29 -0000 From: David Bremner Unlike in the correctness tests, the most common cause of non-zero return seems to be the user interrupting, so killing the run seems like the friendly thing to do. --- performance-test/perf-test-lib.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/performance-test/perf-test-lib.sh b/performance-test/perf-test-lib.sh index 1399d05..fb15028 100644 --- a/performance-test/perf-test-lib.sh +++ b/performance-test/perf-test-lib.sh @@ -51,7 +51,9 @@ time_run () { if test "$verbose" != "t"; then exec 4>test.output 3>&4; fi if ! eval >&3 "/usr/bin/time -f '%e\t%U\t%S\t%M\t%I\t%O' $2" ; then test_failure=$(($test_failure + 1)) + return 1 fi + return 0 } time_done () { -- 1.7.10.4