From: Carl Worth <cworth@cworth.org>
To: racin@free.fr, Sebastian Spaeth <Sebastian@SSpaeth.de>
In-Reply-To:
 <1161359196.2247691263984967906.JavaMail.root@zimbra1-e1.priv.proxad.net>
References:
 <1161359196.2247691263984967906.JavaMail.root@zimbra1-e1.priv.proxad.net>
Date: Wed, 24 Feb 2010 10:53:50 -0800
Message-ID: <87sk8qwjlt.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: [notmuch] [PATCH] add notmuch-show-delete keybinding 'd'
Precedence: list

--=-=-=

On Wed, 20 Jan 2010 11:56:07 +0100 (CET), racin@free.fr wrote:
> I posted a similar patch a while ago, that also did not show deleted
> messages by default. Don't know if Carl wants to integrate this though

OK. When two people are independently contributing similar
functionality, it's more than clear that I'm far too behind on patch
review.

Matthieu, I've just posted my review of your original patch. I think I
like the name "deleted" for the tag rather than "delete", (it's
consistent with "unread" at least that way). And I like the support for
excluding deleted results in that patch as well.

But this patch does have two good ideas not in the other patch, (both of
which I mentioned in the review):

1. It adds a keybinding to the notmuch-show mode

2. It removes the "inbox" and "unread" tags while adding the tag to
   indicate deletion.

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLhXW+6JDdNq8qSWgRArDlAJ9rqHAps2eMtZ0Rp5I9YHuurnchFACeN2DK
zvUrqEHMJtHcD5xpwSZiUqI=
=V/6W
-----END PGP SIGNATURE-----
--=-=-=--