Return-Path: <cworth@cworth.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id BE706431FBD
	for <notmuch@notmuchmail.org>; Sat, 20 Feb 2010 12:19:19 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -3.238
X-Spam-Level: 
X-Spam-Status: No, score=-3.238 tagged_above=-999 required=5
	tests=[ALL_TRUSTED=-1.8, AWL=1.161, BAYES_00=-2.599] autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id bgl88hTEG+sr; Sat, 20 Feb 2010 12:19:19 -0800 (PST)
Received: from yoom.home.cworth.org (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id DDCCD431FAE;
	Sat, 20 Feb 2010 12:19:18 -0800 (PST)
Received: by yoom.home.cworth.org (Postfix, from userid 1000)
	id 8F8AD25427A; Sat, 20 Feb 2010 12:19:18 -0800 (PST)
From: Carl Worth <cworth@cworth.org>
To: david@tethera.net, notmuch@notmuchmail.org
In-Reply-To: <1265942650-30781-1-git-send-email-david@tethera.net>
References: <id:1265942072-30247-3-git-send-email-david@tethera.net>
	<1265942650-30781-1-git-send-email-david@tethera.net>
Date: Sat, 20 Feb 2010 12:19:18 -0800
Message-ID: <87bpfjhd89.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: David Bremner <bremner@unb.ca>
Subject: Re: [notmuch] [PATCH v2] Add functions notmuch-show-get-(bcc, cc,
 date, from, subject, to).
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Feb 2010 20:19:20 -0000

--=-=-=

On Thu, 11 Feb 2010 22:44:10 -0400, david@tethera.net wrote:
> Return the corresponding header field for the current message as a
> string.  These are thin wrappers around notmuch-show-get-header, which
> means they each cause a full parse of the RFC822 header. The main idea
> is to fix an api.

OK. You at least acknowledge the only misgiving I had about this
patch. (And frankly, my own emacs lisp code probably has much worse
performance bugs.) So I'm not going to worry about that for now.

> Sorry, resending with fixed commit message.

Much appreciated.

> +(defun notmuch-show-get-bcc ()
> +  "Return To address of current message"
> +  (notmuch-show-get-header-field 'bcc))
> +
> +(defun notmuch-show-get-cc ()
> +  "Return To address of current message"
> +  (notmuch-show-get-header-field 'cc))
> +
> +(defun notmuch-show-get-date ()
> +  "Return To address of current message"
> +  (notmuch-show-get-header-field 'date))

I fixed the obviously copied documentation strings above, deleted the
trailing whitespace, and applied this patch.

Thanks!

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLgEPG6JDdNq8qSWgRAmhjAKCpeAoZ3fs0ma1ODdX70WiqJ0JHXgCgosV5
YvpLhF1CIvc8NwTVMaDW1U4=
=2NV2
-----END PGP SIGNATURE-----
--=-=-=--