Date: Mon, 23 Nov 2009 10:45:50 -0500
From: Jameson Rollins <jrollins@phys.columbia.edu>
To: Ingmar Vanhassel <ingmar@exherbo.org>
Message-ID: <20091123154550.GA27503@finestructure.net>
References: <46263c600911230731i529f2db5rec11bed02f84ef13@mail.gmail.com>
	<1258990831-sup-2789@cannonball>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc"
Content-Disposition: inline
In-Reply-To: <1258990831-sup-2789@cannonball>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: [notmuch] [patch] Trivial fix for non-root install
Precedence: list


--C7zPtVaVf+AK4Oqc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 23, 2009 at 04:41:23PM +0100, Ingmar Vanhassel wrote:
> Excerpts from Brett Viren's message of Mon Nov 23 16:31:47 +0100 2009:
> > Installing as a normal user fails because the bash completion config
> > files try to install into /etc.  This trivial patch fixes this.
>
> Your patch breaks the more common case of installing as root user. It
> now installs into /usr/etc where bash completions most likely won't be
> found.

I submitted a patch similar to Ingmar's the other day.  I actually
feel like the more common case is to install it locally as a local
user, especially during early development.

jamie.

> > diff --git a/Makefile.config b/Makefile.config
> > index ddc7436..c04d57a 100644
> > --- a/Makefile.config
> > +++ b/Makefile.config
> > @@ -1,3 +1,2 @@
> > -prefix =3D /usr/local
> > -bash_completion_dir =3D /etc/bash_completion.d
> > +bash_completion_dir =3D $(prefix)/etc/bash_completion.d
> >  CFLAGS +=3D -DHAVE_VALGRIND
> >=20
> >=20
> > -Brett.
> --=20
> Exherbo KDE, X.org maintainer
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

--C7zPtVaVf+AK4Oqc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: attachment

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJLCq4qAAoJEO00zqvie6q8EuUQAJkwQjHWt0aoObgGG2JgRIc/
gh5kmXWhR4UkavOKQv4p0cL8kIgpRoHowc44YlzfnfQNqY4y04XpuSB0hZVxPq1M
09E3kwivKj6m6VZwS49FFNlLU0SwvMPBFJ925AqQP0pFfSwZ2KpLOe2OO3wxaJbX
cD5qwguCM3Nc+cTwlDV3/0KhRBwU0c8CcmE+SD+Q92N1wBUXEt38rYn4aCndT958
OdsM1i9V0VwctxYseEvJ1k6NZ4sbx75VdgvUMroGTNij7x+KeTX4eH6jw4w2dmUN
ciot5OOfy7U6SX1j1pYa5I1dYVu6CVOhctXjjbOygU/TALRtEfjSwOE+jusS/5p1
RM6rpEFJy4NKuLcNnkAS66YZahiJLJnosuCv7lpl1EmVt9pgZvnuIUrnIyeSuVro
RxVExDnxvEv+93V5FR/VTzCkyrIZKhI+t2ba/eAfJiqwwon0k8WI+LRdNY46HmGK
fp9QdsSsf3n7vMGX+aUqca7bDFprc/Zzl679CvzvVhpqoGK6cH/np503ZVeWXzBZ
EpFq2bzjBlm1cY/BzDEAwabVGLwU7RyoI3IEagb2yb8OyvjRsmmmvBO91s29wH2k
w9SEZ16AcwMuA9aRA4Cklui0tOO2fDJWpQGfqPEbTUryLYfCYWVfLdNQWBp3BtxE
yx+y+V0SxgP39gyMq6en
=dzyH
-----END PGP SIGNATURE-----

--C7zPtVaVf+AK4Oqc--