From: Carl Worth <cworth@cworth.org>
To: Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/4] Add infrastructure for building shared library on OS
	X.
In-Reply-To: <87sk6xgbft.fsf@yoom.home.cworth.org>
References: <4bc25ea0.86c3f10a.45a3.ffff80d3@mx.google.com>
	<1271029494-89014-3-git-send-email-aaronecay@gmail.com>
	<87sk6xgbft.fsf@yoom.home.cworth.org>
Date: Wed, 14 Apr 2010 11:47:12 -0700
Message-ID: <87mxx5g9cf.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 14 Apr 2010 11:01:58 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Sun, 11 Apr 2010 19:44:53 -0400, Aaron Ecay <aaronecay@gmail.com> wrot=
e:
> > -include $(subdirs:%=3D%/Makefile.local) Makefile.local
> > +include Makefile.config $(subdirs:%=3D%/Makefile.local) Makefile.local
>=20
> This first hunk looks unrelated to what's described in the commit
> message.

Indeed, on further testing this looks like it should have been part of
the previous commit that includes the sub-directory Makefile.local files
before the top-level Makefile.local. Without this piece, I was seeing
the various compat/*.c files being compiled unconditionally.

> But I'd be willing to accept that if necessary---should just remove the
> include of Makefile.config from Makefile.local then I think.

I've gone ahead and done that now. I moved everything concerning
Makefile.config, (dependency, include, and generation), from
Makefile.local up to the top-level Makefile.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLxg2w6JDdNq8qSWgRAoNPAJwNPZSJVGnaB26a7xHP2NHmaNCxnwCfQ1GI
zM2sthAWHDKRHzKkd4lyvV0=
=k5HG
-----END PGP SIGNATURE-----
--=-=-=--