From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH 2/2] notmuch-reply.c: uncrustify
In-Reply-To: <20120112152652.GA18625@mit.edu>
References: <1324135695-15487-1-git-send-email-david@tethera.net>
	<1326197228-10356-1-git-send-email-david@tethera.net>
	<1326197228-10356-3-git-send-email-david@tethera.net>
	<20120112035739.GW20796@mit.edu> <87r4z56pbx.fsf@zancas.localnet>
	<20120112152652.GA18625@mit.edu>
User-Agent: Notmuch/0.11+89~g85665a2 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 21 Jan 2012 15:00:22 -0400
Message-ID: <877h0kdgop.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

On Thu, 12 Jan 2012 10:26:52 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth David Bremner on Jan 12 at  9:08 am:
> > @@ -425,7 +420,7 @@ notmuch_search_command (void *ctx, int argc, char *argv[])
> >      int limit = -1; /* unlimited */
> >  
> >      enum { NOTMUCH_FORMAT_JSON, NOTMUCH_FORMAT_TEXT }
> > -	format_sel = NOTMUCH_FORMAT_TEXT;
> > +    format_sel = NOTMUCH_FORMAT_TEXT;
> 
> This is unfortunate, but other than the format structure flattening,
> the remaining changes look reasonable to me.

I guess we have to accept that this is a big pile of heuristics, as long
as there are not too many cases to be overriden, it should still be a
net win.

FWIW An alternative formatting that does not confuse the indenter is

enum format_enum {
     NOTMUCH_FORMAT_JSON, NOTMUCH_FORMAT_TEXT
} format_sel = NOTMUCH_FORMAT_TEXT;