Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A5ACB431FAE for ; Fri, 27 Nov 2009 06:32:15 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4FXACmas+2wz for ; Fri, 27 Nov 2009 06:32:14 -0800 (PST) Received: from mail-bw0-f224.google.com (mail-bw0-f224.google.com [209.85.218.224]) by olra.theworths.org (Postfix) with ESMTP id 3862F431FBC for ; Fri, 27 Nov 2009 06:32:14 -0800 (PST) Received: by bwz24 with SMTP id 24so1237351bwz.30 for ; Fri, 27 Nov 2009 06:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:cc:subject :in-reply-to:references:date:message-id:mime-version:content-type; bh=UJeUql2OCMP46Oa/OM4JKCmMlKodLmYK22eI9o1F3ds=; b=jm/H76jZEzMrSn8FJX6hdLFbBbTL6K+TrOr8jQkjoFwpZnDEt+B5DDokjJJ5EUhp2z 29CbP2pDnWnuiqH+xisYn79oGeMDDNDTOzE1/2GtZR4IdWdJ3YJ0u/K44E41w47uqpod pKrYN0x7h32hdXYTp64dKdAk6D95nPIiPPFLg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; b=CNZZWevK4E0zbt9HEZ+DOX2lVouTxIr8PtGrV3WpGmXqSZEqzWYEnT0sF62WDc80gr NwWv+SzrCBgQABmp48C2SRKjq6wLCLp+Qjs1Qm6VVJrZGUX3PVXnojcnzWDOewmAWagQ WSIgFoQYlMGJau82G35oXO2RnRyMHeiCpjSOo= Received: by 10.204.24.130 with SMTP id v2mr1197289bkb.33.1259332333259; Fri, 27 Nov 2009 06:32:13 -0800 (PST) Received: from kunyang (vawpc43.ethz.ch [129.132.59.11]) by mx.google.com with ESMTPS id 22sm2103192fkr.27.2009.11.27.06.32.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 27 Nov 2009 06:32:12 -0800 (PST) Sender: Jed Brown From: Jed Brown To: Carl Worth In-Reply-To: <87fx80m5fe.fsf@yoom.home.cworth.org> References: <87pr75q9va.fsf@yoom.home.cworth.org> <1259271410-15336-1-git-send-email-jed@59A2.org> <87fx80m5fe.fsf@yoom.home.cworth.org> Date: Fri, 27 Nov 2009 15:32:44 +0100 Message-ID: <87skc0domr.fsf@59A2.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH 1/2] New function notmuch-search-operate-all: operate on all messages in the current query. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 14:32:15 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 27 Nov 2009 06:02:45 -0800, Carl Worth wrote: > Since this operates via a single call to "notmuch tag" you might mention > here that all tag removals occur before any tag additions. I was unaware of this point, if I do notmuch tag -inbox +star tag:inbox some-expression I will have starred nothing? > > + (unless (string-match-p "^[\+\-][_\+\-\\w]+$" (car words)) > > + (error "Action must be of the form `+thistag -that_tag'")) >=20 > The error message has inconsistent "thistag" and "that_tag". That was somewhat intentional to illustrate that non-alphanumeric characters could be used in tags. Should the alphabet for tags be based on a whitelist or blacklist? It would be rather hard to validate a tag operation when there is no assumption/restriction on the alphabet. Jed --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAksP4wwACgkQU7Rz1O1Q6osrhgCeKMJQWnAUfyTUEhmUc76Dqzde F7AAniUIxCpYHulOFhe5kR8LvAvzftDt =vMpW -----END PGP SIGNATURE----- --=-=-=--