From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: out of tree build fixes
In-Reply-To: <1395276484-22363-1-git-send-email-david@tethera.net>
References: <1395276484-22363-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.17+155~g3416ef5 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 20 Mar 2014 12:29:27 +0200
Message-ID: <m2d2hhduyg.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Thu, Mar 20 2014, David Bremner <david@tethera.net> wrote:

> Apparently we've neglected the out of tree builds even more than
> usual. I originally thought this is what was causing the test failures
> on buildbot. I'm less sure now, but I think these fixes don't hurt
> anything, and they do unbreak out of tree builds for me.
>
> There is certainly still work to be done with our out of tree builds.
> For those of you just joining the party, that doesn't mean we want to
> switch to your favourite build system. Or even to Autotools.
>
> An earlier draft of this series (discussed on IRC) defined a builddir
> variable, but eventually I realized the current directory of make is
> always builddir. So at least for now that doesn't seem to be needed.

LGTM. Too bad we cannot expand $(dir) in recipes (or I don't know how),
and using other variables don't bring any benefit (naming would contain
the 'doc' part and we even cannot check whether the variable is defined
or not...).

>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch