From: Mark Walters <markwalters1009@gmail.com>
To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 0/6] Config-related patches
In-Reply-To: <87zkaelnxr.fsf@qmul.ac.uk>
References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>
	<1334367666-10954-1-git-send-email-novalazy@gmail.com>
	<87zkaelnxr.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.12+128~g0f26d91 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 25 Apr 2012 09:06:15 +0100
Message-ID: <87k414i6bs.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


On Sat, 14 Apr 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> On Sat, 14 Apr 2012, Peter Wang <novalazy@gmail.com> wrote:
>> Changes from v3:
>> - rephrase part of the 'list' implementation as a separate patch
>> - test 'set' on an extant key
>> - test removing keys
>
> This looks good to me. +1
>
> Two minor comments which you might like to consider (but definitely are
> not required):
>     1) You could check that there are no further arguments when the user
>     calls `notmuch config list'
>     2) In the man page you could explicitly say what the output is for a
>     configuration item which has not been set.
>
> Best wishes
>
> Mark

Just to make it completely clear the above was not meant to delay
acceptance of this series: I am quite happy with it as is.

Best wishes

Mark