Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A9CC3431FBC for ; Fri, 27 Jan 2012 02:31:44 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ztT+UfpYkXVz for ; Fri, 27 Jan 2012 02:31:44 -0800 (PST) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 147B5431FB6 for ; Fri, 27 Jan 2012 02:31:44 -0800 (PST) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1Rqj5q-0000Pp-3P; Fri, 27 Jan 2012 10:31:42 +0000 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1Rqj5p-0001ct-79; Fri, 27 Jan 2012 10:31:41 +0000 From: Mark Walters To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects. In-Reply-To: <1327499314-7887-4-git-send-email-dme@dme.org> References: <1327496913-4946-1-git-send-email-dme@dme.org> <1327499314-7887-1-git-send-email-dme@dme.org> <1327499314-7887-4-git-send-email-dme@dme.org> User-Agent: Notmuch/0.11+107~g185f859 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Fri, 27 Jan 2012 10:32:43 +0000 Message-ID: <87ty3h4er8.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 94.192.233.223 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: d5b810ae135be3edf305c826e6d3381f (of first 20000 bytes) X-SpamAssassin-Score: -1.8 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.8 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay * domain * 0.5 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2012 10:31:44 -0000 I am very much not a lisp expert but for what it's worth I read/reviewed the patches and like them with a couple of minor queries that I am happy to be overruled on The patch 1/3 seems to set the show buffer line to *[No Subject]* where it used to be just [No Subject]. (I have no preference: I just wasn't sure if that was intentional. Patch 2/3 is obviously fine and good. Patch 3/3: > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index e6a5b31..c602b3e 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -985,7 +985,7 @@ buffer." > (notmuch-show-next-open-message)) > > ;; Set the header line to the subject of the first open message. > - (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-subject))) > + (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-pretty-subject))) > > (notmuch-show-mark-read))) > > @@ -1216,6 +1216,9 @@ Some useful entries are: > (defun notmuch-show-get-depth () > (notmuch-show-get-prop :depth)) > > +(defun notmuch-show-get-pretty-subject () > + (notmuch-prettify-subject (notmuch-show-get-subject))) > + > (defun notmuch-show-set-tags (tags) > "Set the tags of the current message." > (notmuch-show-set-prop :tags tags) As far as I can see notmuch-show-get-pretty-subject is only called once so I wondered why you bothered with a new function. But as I say I have almost zero lisp experience so no feel for lisp style. Best wishes Mark (sorry for the resend: I sent from the wrong address the first time)