Date: Sat, 11 Apr 2015 09:12:11 +0000
From: Gaute Hope <eg@gaute.vetsj.com>
Subject: Re: [PATCH] Re: Add /renew/ tag to moved/renamed/reflagged messages
To: David Bremner <david@tethera.net>, Baptiste <bateast@bat.fr.eu.org>,
 notmuch@notmuchmail.org
References: <87ioegq5ca.fsf@vm_arch_64.bat.fr.eu.org>
 <87fv9kq1fu.fsf@vm_arch_64.bat.fr.eu.org>
 <87pp7bwn93.fsf@maritornes.cs.unb.ca>
In-Reply-To: <87pp7bwn93.fsf@maritornes.cs.unb.ca>
User-Agent: astroid/vv0.2-23-gd0081277 (https://github.com/gauteh/astroid)
Message-Id: <1428743351-astroid-1-syzinp7fwu-1358@strange>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: list

Excerpts from David Bremner's message of April 11, 2015 1:56:
> Baptiste <bateast@bat.fr.eu.org> writes:
>=20
>> Hi,=20
>>
>>> What about another automatic tag to re-add to an existing mail when =3D=
notmuch new=3D detect a moved, renamed or reflagged message=C2=A0...
>>
>> the following code sample seems to actually do the job=C2=A0=E2=80=A6
>>
>=20
> Sorry I still haven't had a chance to review your patch in detail. A few
> things I did wonder about
>=20
> - There is a patch series in progress to add a "last modified time" to
>   all messages [1]. It seems like this should also work for your case
>   since renaming counts as modification in this context. It might not be
>   quite as easy/efficient for your use case as your proposal, but it
>   seems like it should work.
>=20
> - What about messages added by notmuch-insert? I guess you are maybe not
>   using it, but it seems odd to only support changes detected in
>   notmuch-new.
>=20
> - This might be because I haven't worked through the details, but it
>   isn't obvious to me how your patch behaves with messages with multiple
>   files on disk.
>=20
>=20
>=20
> [1]: id:1428274754-1698-1-git-send-email-david@tethera.net

I think I sent in something similar [2] before the lastmod stuff, there
are some issues with reliably detecting all changes. Especially, changes
that do not result in a rename. It would be made obsolete by the lastmod
series though.

- gaute

[2]: id:1396800683-9164-1-git-send-email-eg@gaute.vetsj.com=20

=