Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8A8B9431FD0 for ; Sat, 9 Jul 2011 10:07:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.789 X-Spam-Level: X-Spam-Status: No, score=-0.789 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J2PMbohVYc0q for ; Sat, 9 Jul 2011 10:07:27 -0700 (PDT) Received: from mail-fx0-f46.google.com (mail-fx0-f46.google.com [209.85.161.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 9C912431FB6 for ; Sat, 9 Jul 2011 10:07:27 -0700 (PDT) Received: by fxh19 with SMTP id 19so2914304fxh.19 for ; Sat, 09 Jul 2011 10:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=fhjZQsEwCQfYIaWyunfNc7MyDzQagv6NwspI62XXKHI=; b=MnqsnZs6aX9Jxh6hfd4LtXpTsweKqH5oHQyuXiclIGKKDIqGuB1zWB4RuLaQdBU6Sm kigRZLNyfVfSZ4HClG4U0pCDc/WcvWG67bMvT6IX4GH4AyqmQHuD5COVTDqYWrdXcQY6 9SijA9yq6JvWBlJwrI3K4f+BLlYaMYUrPubgs= Received: by 10.223.7.150 with SMTP id d22mr4805092fad.17.1310231245838; Sat, 09 Jul 2011 10:07:25 -0700 (PDT) Received: from localhost (dslb-178-004-073-181.pools.arcor-ip.net [178.4.73.181]) by mx.google.com with ESMTPS id q14sm1572426faa.27.2011.07.09.10.07.21 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 09 Jul 2011 10:07:21 -0700 (PDT) From: Daniel Schoepe To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello In-Reply-To: <87box48jkc.fsf@steelpick.2x.cz> References: <1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com> <1310079227-19120-2-git-send-email-daniel.schoepe@googlemail.com> <87box48jkc.fsf@steelpick.2x.cz> User-Agent: Notmuch/0.5-329-g0b5d38d (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 09 Jul 2011 19:07:13 +0200 Message-ID: <87fwmf2xj2.fsf@gilead.invalid> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jul 2011 17:07:28 -0000 --=-=-= On Sat, 09 Jul 2011 01:00:03 +0200, Michal Sojka wrote: > Yes, this is definitely a good idea. My last comment to the patch is > that I do not like the use of plists in customization interface. It is > especially weird in the case of boolean options like hide-if-empty, > because they actually have three states: disabled, off and on. And this > make not a lot of sense. I just realized we overlooked the simplest solution: Changing the (boolean ..) elements to (const :tag "..." t) elements resolves this nicely. I'll send a new version shortly. Cheers, Daniel --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOGIrBAAoJEIaTAtce+Z+J0NEP/jSRpSEJlBOPT0Q+D42pTYUz ECYfw7f0TWwv9axrK9YtOUTYE37ox4TUtUTsfr0Q3frJ0ru2MmMI+XsJg+8wMnQG dMU1I4OwfnmL6zFOI2xYZpy7Rvrf0VKCA1IUZwaL1FhSfM495M6esXUiIqEm70eE WW7aQOTZXwowKV01IQr8CJu1u6GgNK48twGboq8AvpqAcABmODTTVpbzPAt8lP2c GlbHOLaiD258N4zG7ZTUdTLWpCvhpp8IyFA0BJfC65fWj9QB9VaBlWE9CHBBERCB tfoGvIBnmTbEsvY3N0b3WigqMEV7H3VqkzBeu5F4gcb3UWI/PTIb6Oqis8EYPngA LtW3n9Z8kTeXpeBbrAYrUjeE0nKUYd0OTRzX6gaTjBrsp8D4lo30pstD6BlVuZBH CInzdiAxpjUBA6HdAbaEROUy+oHgF1ArCAXBjV71tfrfE7RjbfFc7qemistTeW0A snpbpVJ6aIX06FfUabtgReIYmioc4/DHTQKrSmQV3JUYbvxMx619AwGz/NzneZFK MY5sGRjVMMhI2UgR4t5/1jKwBlgA6c/bYZtqYpNVFj7j1fLBnlutEwWkUlW4haxJ 3raSHb2KmsnXa0HBRsHLelDrTc/utCDmNf3QnmGihBpskl608QbtOKYjM5tqyoFr ifVJrDfIV+vnknMlnhRL =jAWN -----END PGP SIGNATURE----- --=-=-=--