Return-Path: <dkg@fifthhorseman.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id EB1086DE02C6
 for <notmuch@notmuchmail.org>; Fri,  8 Apr 2016 18:54:51 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.000]
 autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id d_C2-iBiywN0 for <notmuch@notmuchmail.org>;
 Fri,  8 Apr 2016 18:54:44 -0700 (PDT)
Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])
 by arlo.cworth.org (Postfix) with ESMTP id ED8DC6DE028C
 for <notmuch@notmuchmail.org>; Fri,  8 Apr 2016 18:54:43 -0700 (PDT)
Received: from fifthhorseman.net (unknown [201.140.212.132])
 by che.mayfirst.org (Postfix) with ESMTPSA id 02CFA1006F;
 Fri,  8 Apr 2016 21:54:36 -0400 (EDT)
Received: by fifthhorseman.net (Postfix, from userid 1000)
 id E75572003D; Fri,  8 Apr 2016 22:54:31 -0300 (ART)
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2 2/7] verify during thread-breakage that messages are
 removed as well
In-Reply-To: <87zit7fs7m.fsf@zancas.localnet>
References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net>
 <1459606541-23889-1-git-send-email-dkg@fifthhorseman.net>
 <1459606541-23889-2-git-send-email-dkg@fifthhorseman.net>
 <87zit7fs7m.fsf@zancas.localnet>
User-Agent: Notmuch/0.21+124~gbf604e9 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Fri, 08 Apr 2016 22:54:31 -0300
Message-ID: <87d1pzr1go.fsf@alice.fifthhorseman.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Apr 2016 01:54:52 -0000

On Tue 2016-04-05 22:20:45 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>>  
>> +test_subject_count() {
>> +    notmuch new >/dev/null
>> +    test_begin_subtest "${3:-looking for $2 instance of '$1'}"
>> +    count=$(notmuch count --output=threads "$1")
>> +    test_expect_equal "$count" "$2"
>> +}
>
> It's confusing that this doesn't have anything to do with the subject:
> prefix or the corresponding header.

Sigh.  sorry, i just realized i missed this absolutely correct comment
when preparing the v3 series.  v4 is on its way, and hopefully it
addresses all the excellent feedback i got here.

apologies for the noise.

       --dkg