From: Thomas Jost <schnouki@schnouki.net>
To: Austin Clements <amdragon@MIT.EDU>, Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6
In-Reply-To: <20120118173534.GB16740@mit.edu>
References: <8739bea9lc.fsf@thor.loria.fr>
	<1326797453-9405-1-git-send-email-schnouki@schnouki.net>
	<1326797453-9405-2-git-send-email-schnouki@schnouki.net>
	<20120117222546.GT16740@mit.edu> <yf639bd5suz.fsf@taco2.nixu.fi>
	<20120118173534.GB16740@mit.edu>
User-Agent: Notmuch/0.11+95~g205cf08 (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-unknown-linux-gnu)
Date: Fri, 20 Jan 2012 00:33:50 +0100
Message-ID: <87r4yv2roh.fsf@schnouki.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 18 Jan 2012 12:35:34 -0500, Austin Clements <amdragon@MIT.EDU> wrot=
e:
> Quoth Tomi Ollila on Jan 18 at 10:15 am:
> > On Tue, 17 Jan 2012 17:25:46 -0500, Austin Clements <amdragon@MIT.EDU> =
wrote:
> > > Quoth Thomas Jost on Jan 17 at 11:50 am:
> > > >=20=20
> > > > +#ifdef GMIME_26
> > > > +    /* sig_list may be created in both above cases, so we need to
> > > > +     * cleanly handle it here. */
> > > > +    if (node->sig_list) {
> > > > +	GMimeSignatureList **proxy =3D
> > > > +	    talloc (node, GMimeSignatureList *);
> > >=20
> > > This doesn't need to be split into two lines.
> > >=20
> > > > +	*proxy =3D node->sig_list;
> > > > +	talloc_set_destructor (proxy, _signature_list_free);
> > > > +    }
> > > > +#else
> > > >      if (node->verify_attempted && !node->sig_validity)
> > > >  	fprintf (stderr, "Failed to verify signed part: %s\n",
> > > >  		 (err ? err->message : "no error explanation given"));
> > > > +#endif
> > >=20
> > > I'd rather see the above as a separate #ifdef GMIME_26 and #ifndef
> > > GMIME_26, since they aren't logical alternates of each other.
> >=20
> > That reminds me that it should then be like GMIME_ATLEAST_26, so
> > that this might be useful when GMIME > 2.6 is available...
>=20
> Hopefully before GMIME 2.8 comes out, we'll be able to remove all of
> the GMIME 2.4 compatibility.  But GMIME_ATLEAST_26 would be fine, too.

Heh, maybe things will change again in 2.8 and "ATLEAST_26" will become
"ONLY_26"... But changed to GMIME_ATLEAST_26 anyway, thanks for the
suggestion :)

=2D-=20
Thomas/Schnouki

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJPGKheAAoJEMPdciX+bh5ICv8IAJ5I9VOggDSgx5tAE1pWzYDs
45klZWTzDGEJkk3F+7AD+NqQYm6WCPPhKcViQoYsmVfBcWlMOu0jeALoTomiKjK3
AfeXAhsJbsilf6KoDbMqn4QpY1FM/ZELZqZbLnHNzoWqC3dNVvybhvJIKwI1yByU
BYgOrbGrq5X7OvyDWYOrcQwEswapJU9zjrSlwZyiHvSDaJVP0pFfyxblzs92V3hK
GggsQxC58xWQtcckiPUPl3GKlJPTOsR1Gvozf6oZSCaj1Dw8ZwNa1IBUdmBIhEtN
+Za0ZvnnObTwJeXfCko47Nhyeju1OFmIHzUzPWA05AYU0onitye3nQd0/f0uopQ=
=uCtu
-----END PGP SIGNATURE-----
--=-=-=--