From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ben Gamari <bgamari.foss@gmail.com>, Jani Nikula <jani@nikula.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH RFC?] Compactification support
In-Reply-To: <87zk5oz4fh.fsf@gmail.com>
References: <1345476704-17091-1-git-send-email-bgamari.foss@gmail.com>
	<87boi41xdu.fsf@nikula.org> <87zk5oz4fh.fsf@gmail.com>
User-Agent: Notmuch/0.14+8~gd6b499d (http://notmuchmail.org) Emacs/23.1.1
	(x86_64-redhat-linux-gnu)
Date: Tue, 21 Aug 2012 18:25:06 +0300
Message-ID: <m2wr0s6ze5.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, Aug 21 2012, Ben Gamari <bgamari.foss@gmail.com> wrote:

> Jani Nikula <jani@nikula.org> writes:
>
>> On Mon, 20 Aug 2012, Ben Gamari <bgamari.foss@gmail.com> wrote:
>>> Here is a small patchset adding support for database compaction when
>>> supported by Xapian. Here I add a function which both compacts and
>>> closes the database.
>>
>> What are the benefits of this compared to xapian-compact [1]?
>>
> I think it's a bit of a shame you are currently forced to interact with
> Xapian directly (an implementation detail) to compact the database. This
> set seeks to abstract this out. This is especially important since it's
> not too difficult to get the invocation of xapian-compact wrong
> (e.g. forget --no-renumber).

Better reason would be that xapian-compact(1) may not be available although
the library is -- if the command is available it is easy to execve(2) it
with correct arguments... (?)

Tomi

> Also, in the past Carl (id:"87ocl1lut1.fsf@yoom.home.cworth.org") has
> mentioned it would be nice if compact would be run after the initial run
> of "notmuch new". This patchset sets the groundwork to enable this.
>
> Cheers,
>
> - Ben