From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] test: add more maildir flag syncing related tests to
	insert
In-Reply-To: <87mwnus1bg.fsf@zancas.localnet>
References: <1378170613-3584-1-git-send-email-david@tethera.net>
	<1378185543-25271-1-git-send-email-jani@nikula.org>
	<87mwnus1bg.fsf@zancas.localnet>
User-Agent: Notmuch/0.15.2+177~gb1ba76c (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Tue, 03 Sep 2013 14:11:12 +0200
Message-ID: <87fvtmds0v.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 03 Sep 2013, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>>  
>> +test_begin_subtest "Insert message with default tags stays in new/"
>> +gen_insert_msg
>> +notmuch insert < "$gen_msg_filename"
>> +output=$(notmuch search --output=files id:$gen_msg_id)
>> +dirname=$(dirname "$output")
>> +test_expect_equal "$dirname" "$MAIL_DIR/new"
>
> I'm not sure if this is a bug or a feature, but this enforces a
> constraint on the default tags that notmuch ships enabled. Is that what
> we want, or would it be better to set unread explicitely here?

We already pretty heavily depend on those default tags, so I'd say just
leave it like this. If we want to fix it later, there's some other
fixing to do too. Try this patch and 'make test':

diff --git a/notmuch-config.c b/notmuch-config.c
index 6845e3c..8362c13 100644
--- a/notmuch-config.c
+++ b/notmuch-config.c
@@ -365,8 +365,8 @@ notmuch_config_open (void *ctx,
     }
 
     if (notmuch_config_get_new_tags (config, &tmp) == NULL) {
-        const char *tags[] = { "unread", "inbox" };
-        notmuch_config_set_new_tags (config, tags, 2);
+        const char *tags[] = { "flagged" };
+        notmuch_config_set_new_tags (config, tags, 1);
     }
 
     if (notmuch_config_get_new_ignore (config, &tmp) == NULL) {

I get:

Notmuch test suite complete.
396/579 tests passed.
183 tests failed.


BR,
Jani.