Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3CFA6431FB6 for ; Fri, 27 Jan 2012 08:37:54 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U1Mamt-h4HU5 for ; Fri, 27 Jan 2012 08:37:53 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 48928431FAE for ; Fri, 27 Jan 2012 08:37:53 -0800 (PST) Received: by bkbzt19 with SMTP id zt19so1800516bkb.26 for ; Fri, 27 Jan 2012 08:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=JlyoodYhO9vaZ0YV6NZfes1lkbVNC4jR/kEwH/EpprQ=; b=b2GiScEjNUBqbXQli5SJve0i4ityEeBEbQa0uDnsu5/IqeJeAJG8WlvvB+MJh6DmgS /NKeGDU3MZZV9sZ/yhyoiVLVladn5Usz2n6YFfM+1z+NGtFg27pJrKV5UOmfM3iwOgTW epaxkBLGfC1Wja7PNRtkBAX+sNT9I7UlPQoAg= Received: by 10.205.128.4 with SMTP id hc4mr3346825bkc.13.1327682269089; Fri, 27 Jan 2012 08:37:49 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id sp6sm17144228bkb.2.2012.01.27.08.37.47 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Jan 2012 08:37:47 -0800 (PST) From: Dmitry Kurochkin To: Pieter Praet , David Edmondson Subject: Re: [RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'. In-Reply-To: <878vkt35ao.fsf@praet.org> References: <87pqe6vcgv.fsf@praet.org> <1327583610-30085-1-git-send-email-pieter@praet.org> <878vkt35ao.fsf@praet.org> User-Agent: Notmuch/0.11+116~ge6e10b8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 27 Jan 2012 20:36:40 +0400 Message-ID: <87zkd9je5j.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2012 16:37:54 -0000 On Fri, 27 Jan 2012 09:42:23 +0100, Pieter Praet wrote: > On Thu, 26 Jan 2012 14:40:26 +0000, David Edmondson wrote: > > In general, I like this. > > > > - I think that the stash function(s) should take an optional argument > > specifying the archive to use. That will make testing simpler and also > > allow people to produce preferred bindings more easily. > > > > Agreed. In fact, apparently that last patch [1] of mine made the test > suite hang @ emacs:"Stashing in notmuch-show" due to it waiting for > `completing-read' to finish... Sorry for that. > > > - "Message archive: " feels better than "ML Archive: ", but I don't > > really care. > > > > Agreed. > FWIW I believe "Mailing list archive" would be better. Regards, Dmitry > > - Don't base the patch on the thing that I posted, just on master from > > the repository - no need to make David's life harder. > > Seeing as how it was only a minor improvement to your idea (and further > discussion/correction was probably appropriate), I intended for you to > squash it into your original patch. > > Anyways, patch (relative to master) follows... > > > Peace > > -- > Pieter > > [1] id:"1327583610-30085-1-git-send-email-pieter@praet.org" > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch