From: Mark Walters <markwalters1009@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 0/2]  emacs: show: redesign unread/read logic
In-Reply-To: <cunlhubcq6e.fsf@hotblack-desiato.hh.sledj.net>
References: <1399594808-2815-1-git-send-email-markwalters1009@gmail.com>
	<cunlhubcq6e.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Fri, 09 May 2014 12:28:51 +0100
Message-ID: <87d2fnmbrg.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Fri, 09 May 2014, David Edmondson <dme@dme.org> wrote:
> On Fri, May 09 2014, Mark Walters wrote:
>> This is v4 of this set. v3 is at id:1395777793-13297-1-git-send-email-markwalters1009@gmail.com
>>
>> David (dme) was not keen on the logic in the previous patch so I have
>> tried to make it rather more customisable and made this version much
>> closer to the existing logic.
>>
>> This version marks the current message read if it is open. It doesn't
>> care how you get there: whether it is notmuch commands n/N/p/P next
>> message etc, emacs commands like scroll up, mouse clicks etc.
>>
>> The only proviso is it will only mark a message read once (in a single
>> buffer and between refreshes) as otherwise it is impossible for a user
>> to choose to mark a message unread.
>
> This version looks good to me, thanks for considering the feedback.

Hi

Thanks for looking and testing.

>> I, personally, like my previous logic much more. But with this setup
>> that can be customized easily in my .emacs (we may choose to add other
>> options into mainline later). Also I think this series fixes all of
>> the problems with the current read/unread logic mentioned in
>> id:87a9atmpkf.fsf@qmul.ac.uk are fixed.
>
> Just to confirm: you can get your desired behaviour by writing an
> alternative `notmuch-show-mark-read-function'?

Yes I can confirm that. So if this went in I can get the behaviour of
the earlier series without needing to patch notmuch.

We can decide later if we want to include it (and other possible mark
read functions) as an option, or as a contrib file, or just on the wiki.

Best wishes

Mark