Return-Path: <dkg@fifthhorseman.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id C3B4C6DE0231
 for <notmuch@notmuchmail.org>; Tue,  9 Feb 2016 17:01:47 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.019
X-Spam-Level: 
X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5
 tests=[AWL=-0.019] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 5oLSQsf2_uTn for <notmuch@notmuchmail.org>;
 Tue,  9 Feb 2016 17:01:45 -0800 (PST)
Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])
 by arlo.cworth.org (Postfix) with ESMTP id 844586DE021E
 for <notmuch@notmuchmail.org>; Tue,  9 Feb 2016 17:01:45 -0800 (PST)
Received: from fifthhorseman.net (unknown [38.109.115.130])
 by che.mayfirst.org (Postfix) with ESMTPSA id CE75DF997;
 Tue,  9 Feb 2016 20:01:42 -0500 (EST)
Received: by fifthhorseman.net (Postfix, from userid 1000)
 id 682C51FF75; Tue,  9 Feb 2016 20:01:43 -0500 (EST)
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
 Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v3 15/16] added notmuch_message_reindex
In-Reply-To: <87mvr9s8gy.fsf@servo.finestructure.net>
References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>
 <1454272801-23623-16-git-send-email-dkg@fifthhorseman.net>
 <87mvr9s8gy.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.21+72~gd8c4f1c (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Tue, 09 Feb 2016 20:01:43 -0500
Message-ID: <87oabpnzt4.fsf@alice.fifthhorseman.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Feb 2016 01:01:48 -0000

On Tue 2016-02-09 19:41:01 -0500, Jameson Graef Rollins wrote:
> On Sun, Jan 31 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
>> This new function asks the database to reindex a given message, using
>> the supplied indexopts.
>>
>> This can be used, for example, to index the cleartext of an encrypted
>> message.
>
> I just wanted to mention that I think there's a problem with the reindex
> functionality introduced in this patch (or in 16/16).  It looks like
> this function irrevocably busts apart threads.  dkg and I are
> investigating.

it doesn't appear to be irrevocable to me, but it is definitely doing
something weird with threading.

we have a three message thread tagged "weird-thread":

  ( a ← b ← c )

if i do:

   notmuch reindex id:a

then we see two threads:

  ( a ) , ( b ← c )

if i then do:

   notmuch reindex id:b

then i see two threads:


   ( a ← b ) ,  ( c )


and if i then do:

   notmuch reindex id:c

then i see one thread again:

   ( a ← b ← c )

but interestingly, reindexing all the messages together by search tearm

  notmuch reindex tag:weird-thread

doesn't affect the threading.


i think this is happening without regard to --try-decrypt, fwiw.

  --dkg