Date: Fri, 4 Dec 2009 19:20:50 -0500
From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Carl Worth <cworth@cworth.org>
Message-ID: <20091205002050.GA26479@finestructure.net>
References: <1259452657-27608-1-git-send-email-jrollins@finestructure.net>
	<87ocmee0sg.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk"
Content-Disposition: inline
In-Reply-To: <87ocmee0sg.fsf@yoom.home.cworth.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix=
 and properly create Makefile.config
Precedence: list


--qDbXVdCdHGoSgWSk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 04, 2009 at 04:12:47PM -0800, Carl Worth wrote:
> Handling --prefix will be a nice addition to our configure script. So,
> thanks!

Yeah, it's definitely needed for the Debian packaging as well.

> Your commit message has that flag word of "also" in it, and as it turns
> out, the removal of Makefile.config from the repository has actually
> happened already. But that was easy enough to fix.

I was thinking that the removal of the Makefile.config from the repo
went together with the new auto-generation of that file from configure
script.  Do you think they still should have been separate patches?

> > +# option parsing
> > +for option; do
> > +    if [ "${option%=3D*}" =3D '--prefix' ] ; then
> > +	PREFIX=3D"${option#*=3D}"
> > +    fi
> > +done
>=20
> I've gone ahead and committed that now. Then I noticed that we should
> really use ${option%%=3D*} to support the case of an option value
> containing an '=3D' character. So I fixed that.

Ah, good catch.  Sorry about that. =20

> Our configuration system certainly isn't as full-featured yet as a
> standard autoconf-based configure script, but I'm quite happy with how
> clean it is for both users and developers.

Autoconf terrifies me, so I agree I'm quite happy with the simple
configure script we have right now.  If it gets the job done without
having to deal with autoconf then that's great in my book.

jamie.

--qDbXVdCdHGoSgWSk
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: attachment

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJLGadeAAoJEO00zqvie6q87KwP/RNP7FehU5TI7K3tQdFlF35B
7DS4sNp7N+O0fnkE2V4M+b9WCXwZkQ9i9d6BmefLXM/GUkgdKP+X90GygzW7POvv
/iHwk0XJuU1drq5uGk4Dt/rnlGLQI988lLh4JA+Fv6VOgxDlXGeYA/2ATGDLJgLx
wq0UuWqApYongpmnJ8RwDeD9QlJK8TBxsfBjGZfzj2boo8r4kJ1iU3NHID/MjetV
/WF4LM7zAfU7wa5wQOu54rOGOg6WULB36wjpcy2CvXv2kWemN1zQ2ImLx935q/BD
KFLEauadZTcKuy2ep0AY8tKqUeytAvilxhunbVyaY0pg+561gnygzqy/Wh31OL74
SYkKN3nd+ZUp6eocOaEVooOJp52X+xH1wfMo1jMRTMB26zhAUt35uULbRt+fzdsA
URprLhRgQh4spRP9tqfmY3Jbgef48OjQV5r228kkeMpNu3tRH81ngyunU7YnL32u
RoE4ZK1EQQ/q7mqXTvZNl7TZnETbNOi+VEe1JvglQHFM6guitXVfgCugw+HTtA5n
0mcxWRKhbaeGkd3dwJQNb8w++UzFW8fA4hao6M14jZnqzKklLfRtTTVRzHFZXcWA
Zx7uoUoQido2dw7+locnXW/8X43ORHlFcD8+Kze4KuE3mA1X3xSExz4ngx2lLZka
cOk5+oJJ8VgWhZkd18hi
=WZqM
-----END PGP SIGNATURE-----

--qDbXVdCdHGoSgWSk--