Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BDEC4429E27 for ; Sat, 25 Jun 2011 05:46:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hyS-ArDy9gm8 for ; Sat, 25 Jun 2011 05:46:16 -0700 (PDT) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 269C7431FD0 for ; Sat, 25 Jun 2011 05:46:16 -0700 (PDT) Received: from zancas.localnet (fctnnbsc30w-142167176081.pppoe-dynamic.High-Speed.nb.bellaliant.net [142.167.176.81]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p5PCkA9B027917 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sat, 25 Jun 2011 09:46:12 -0300 Received: from bremner by zancas.localnet with local (Exim 4.76) (envelope-from ) id 1QaSFW-0002iU-Bq; Sat, 25 Jun 2011 09:46:10 -0300 From: david@tethera.net To: notmuch@notmuchmail.org Subject: [PATCH] libnotmuch: fix typos in CLEAN setting, add file Date: Sat, 25 Jun 2011 09:45:58 -0300 Message-Id: <1309005958-10409-1-git-send-email-david@tethera.net> X-Mailer: git-send-email 1.7.5.3 In-Reply-To: <87aad7ce2w.fsf@yoom.home.cworth.org> References: <87aad7ce2w.fsf@yoom.home.cworth.org> Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2011 12:46:17 -0000 From: David Bremner - c0961e6 introduced a missing slash between $(dir)$(LIBNAME) and missing $(dir) in front of libnotmuch.a - cdf1c70a created a file $(dir)/notmuch.h.gch and neglected to add it to CLEAN --- Here is an updated version. I'm not sure the best way to do a test of the cleaning; maybe we should ship a MANIFEST file containing the output of git ls-files. I'm not sure how much churn this would cause in git. Perhaps it could be treated like version, and generated from git if possible. In any case I guess this couldn't really be part of our regular test suite, because all the other tests would fail ;). lib/Makefile.local | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/Makefile.local b/lib/Makefile.local index a33ba34..eaa8af4 100644 --- a/lib/Makefile.local +++ b/lib/Makefile.local @@ -103,4 +103,6 @@ install-$(dir): $(dir)/$(LIBNAME) $(LIBRARY_INSTALL_POST_COMMAND) SRCS := $(SRCS) $(libnotmuch_c_srcs) $(libnotmuch_cxx_srcs) -CLEAN := $(CLEAN) $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINKER_NAME) $(dir)$(LIBNAME) libnotmuch.a notmuch.aux notmuch.sym +CLEAN += $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINKER_NAME) +CLEAN += $(dir)/$(LIBNAME) $(dir)/libnotmuch.a notmuch.aux notmuch.sym +CLEAN += $(dir)/notmuch.h.gch -- 1.7.5.3