From: Mark Walters <markwalters1009@gmail.com>
To: Peter Feigl <craven@gmx.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/5] New output format sexp (Lisp S-Expressions)
In-Reply-To: <1354779189-12231-1-git-send-email-craven@gmx.net>
References: <1354632382-15609-1-git-send-email-craven@gmx.net>
	<1354779189-12231-1-git-send-email-craven@gmx.net>
User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Thu, 06 Dec 2012 08:22:15 +0000
Message-ID: <87sj7jpp3c.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


On Thu, 06 Dec 2012, Peter Feigl <craven@gmx.net> wrote:
> This patch series adds a new output format "sexp" to notmuch-reply,
> notmuch-show and notmuch-search. These are useful for the Android mobile
> client and perhaps other Lisp programs as well.
> After the switch to a generic structured output printer, which was
> committed some months ago, these patches just add another one (like the
> json structured output printer).
> Basic tests and updates to the man pages are also included.
>
> This version includes the fixes according to Austin Clements'
> comments. It also changes the output from alists to plists, as these
> should work just as fine on all Lisps.

This is looking very nice: I haven't reviewed the first patch (the
sprinting itself) but the others look good (modulo the two small
points). I can confirm that the output works in notmuch show (with a two
line tweak to use s-expressions).

Best wishes

Mark


>
> Peter Feigl (5):
>   Adding an S-expression structured output printer.
>   Rename the -json printer functions in notmuch-reply and notmuch-show
>     to     generic -sprinter functions.
>   Use the S-Expression structured printer in notmuch-show,
>     notmuch-reply     and notmuch-search.
>   Adding tests for --format=sexp.
>   Updating man pages for new S-Expression output format.
>
>  Makefile.local            |   1 +
>  devel/schemata            |   8 +-
>  man/man1/notmuch-reply.1  |  14 ++-
>  man/man1/notmuch-search.1 |  15 +--
>  man/man1/notmuch-show.1   |  36 +++++--
>  notmuch-client.h          |   8 +-
>  notmuch-reply.c           |  48 ++++++----
>  notmuch-search.c          |   6 +-
>  notmuch-show.c            |  65 +++++++------
>  sprinter-sexp.c           | 238 ++++++++++++++++++++++++++++++++++++++++++++++
>  sprinter.h                |   4 +
>  test/notmuch-test         |   1 +
>  test/sexp                 |  48 ++++++++++
>  13 files changed, 423 insertions(+), 69 deletions(-)
>  create mode 100644 sprinter-sexp.c
>  create mode 100755 test/sexp
>
> -- 
> 1.8.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch