Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5A3D5431FB6 for ; Wed, 21 Nov 2012 19:48:20 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YGGxCD0MhcSW for ; Wed, 21 Nov 2012 19:48:16 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 74773431FAF for ; Wed, 21 Nov 2012 19:48:16 -0800 (PST) Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.89.108] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TbNls-00032L-It; Wed, 21 Nov 2012 23:48:13 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TbNlm-0000xz-Ry; Wed, 21 Nov 2012 23:48:06 -0400 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH v3 1/2] notmuch-show.el: import calendar data with public function after CR removal In-Reply-To: <1352376480-29961-2-git-send-email-tomi.ollila@iki.fi> References: <1352376480-29961-1-git-send-email-tomi.ollila@iki.fi> <1352376480-29961-2-git-send-email-tomi.ollila@iki.fi> User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1 (x86_64-pc-linux-gnu) Date: Wed, 21 Nov 2012 23:48:06 -0400 Message-ID: <87vccywb61.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - Cc: tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2012 03:48:20 -0000 Tomi Ollila writes: > notmuch-get-bodypart-content provides raw data to its caller so > that it can be stored verbatim whenever needed. icalendar functions > expect Emacs to do EOL conversion for the data given to these. Therefore > it the CRLF -> LF conversion is now done explicitly. > > The calls to private functions icalendar--convert-ical-to-diary and > icalendar--read-element are replaced with call to public function > icalendar-import-buffer. This code looks straightforward to me. Any objections to merging?