Sender: Michal Nazarewicz <mpn@google.com>
From: Michal Nazarewicz <mina86@mina86.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] test: fix count test
In-Reply-To:
 <0ca075ab5fb0d886d0235c1f0549db8b0b14c9b5.1354656085.git.jani@nikula.org>
Organization: http://mina86.com/
References: <cover.1354656085.git.jani@nikula.org>
	<0ca075ab5fb0d886d0235c1f0549db8b0b14c9b5.1354656085.git.jani@nikula.org>
User-Agent: Notmuch/ (http://notmuchmail.org) Emacs/24.2.50.1
	(x86_64-unknown-linux-gnu)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC
Date: Wed, 05 Dec 2012 00:04:20 +0100
Message-ID: <xa1tfw3l2zd7.fsf@mina86.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 04 2012, Jani Nikula wrote:
> The quoting for ${SEARCH} is broken when it's supposed to be '*', and

Why is it broken?  It does not appear to be broken to me and in fact the
test passes.

> it seems tricky to get it right. Just drop the variable and use '*'
> directly. Before this, none of the messages ever matched, and the test
> was comparing zeros.
> ---
>  test/count |   23 ++++++++++-------------
>  1 file changed, 10 insertions(+), 13 deletions(-)
>
> diff --git a/test/count b/test/count
> index 300b171..8e587ff 100755
> --- a/test/count
> +++ b/test/count
> @@ -4,37 +4,34 @@ test_description=3D'"notmuch count" for messages and th=
reads'
>=20=20
>  add_email_corpus
>=20=20
> -SEARCH=3D"\"*\""
> -
>  test_begin_subtest "message count is the default for notmuch count"
>  test_expect_equal \
> -    "`notmuch search --output=3Dmessages ${SEARCH} | wc -l`" \
> -    "`notmuch count ${SEARCH}`"
> +    "`notmuch search --output=3Dmessages '*' | wc -l`" \
> +    "`notmuch count '*'`"
>=20=20
>  test_begin_subtest "message count with --output=3Dmessages"
>  test_expect_equal \
> -    "`notmuch search --output=3Dmessages ${SEARCH} | wc -l`" \
> -    "`notmuch count --output=3Dmessages ${SEARCH}`"
> +    "`notmuch search --output=3Dmessages '*' | wc -l`" \
> +    "`notmuch count --output=3Dmessages '*'`"
>=20=20
>  test_begin_subtest "thread count with --output=3Dthreads"
>  test_expect_equal \
> -    "`notmuch search --output=3Dthreads ${SEARCH} | wc -l`" \
> -    "`notmuch count --output=3Dthreads ${SEARCH}`"
> +    "`notmuch search --output=3Dthreads '*' | wc -l`" \
> +    "`notmuch count --output=3Dthreads '*'`"
>=20=20
>  test_begin_subtest "thread count is the default for notmuch search"
>  test_expect_equal \
> -    "`notmuch search ${SEARCH} | wc -l`" \
> -    "`notmuch count --output=3Dthreads ${SEARCH}`"
> +    "`notmuch search '*' | wc -l`" \
> +    "`notmuch count --output=3Dthreads '*'`"
>=20=20
> -SEARCH=3D"from:cworth and not from:cworth"
>  test_begin_subtest "count with no matching messages"
>  test_expect_equal \
>      "0" \
> -    "`notmuch count --output=3Dmessages ${SEARCH}`"
> +    "`notmuch count --output=3Dmessages from:cworth and not from:cworth`"
>=20=20
>  test_begin_subtest "count with no matching threads"
>  test_expect_equal \
>      "0" \
> -    "`notmuch count --output=3Dthreads ${SEARCH}`"
> +    "`notmuch count --output=3Dthreads from:cworth and not from:cworth`"
>=20=20
>  test_done

--=20
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o
..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =
 (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: text/plain


--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJQvoF0AAoJECBgQBJQdR/09hQP/R0VhofnHUmYXItJWr2bOBZB
3ExhvQLH3/vOeKSf0kwU/rBwUod2yEVBC9nSJyztPmi2vDUI7QBwxi2IEOG7ophW
8ko4lBk6ibc6f48eqBHExP1eB6MIUn2L/oQA+uED/WmTac9nVXP566+0t+SKpYBJ
z26peegUP20JNHk4RK3EPBw/xP54MVwBmjD8I4TQFUv5nXUMoftrQ7Ax4g4QmFdq
a2IFhCGf6w5owWEpqMV/gr1DBGOQGFtGZicHascA/SIIZ/5eqnqdC9c25TS5bU84
fOn0N8L9uKYn04Gw6vcmKcTqdNwRM2e3jDCKS0AAdIuw7zuAsG3yxHaqGF7MxwzD
sJzJg+ml49ZKuQIVCtz5jkTFgeIrLjokwbQuREivDpQkW3Uc8Em6KfzB+Cibq3Bw
65mfSCWlacWfaPWNYY/2Lb+y5e6NMN0JTwZfLSuJRcBjM+FfEuazsQXs1QDd0uJS
Q2NzRsa1gm3dcodqV4pHVWtAOgIRwuVOKKFa5m7aqPQPPxO8WcQb2Mp1u0CfKWnV
sOTYEQ6mgKLTmFKjOpvsaANgsNhGLktQViYmeR7B7jrhiQKGIExNYgfH9DIIJeMh
sH3zfoW5uJn6w+Z1h79O7E55XiQM/xKF5c1BHJ3KbIC9Emz+DhlkVaqNR2xkqe8/
sn3kud6sKU/ZnCi0CZ0S
=ZF8K
-----END PGP SIGNATURE-----
--==-=-=--

--=-=-=--