Return-Path: <amdragon@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 22EF3429E20
	for <notmuch@notmuchmail.org>; Mon,  9 May 2011 05:10:15 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.698
X-Spam-Level: 
X-Spam-Status: No, score=-0.698 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
	HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 4dzO8KFS-Lg5 for <notmuch@notmuchmail.org>;
	Mon,  9 May 2011 05:10:13 -0700 (PDT)
Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com
	[209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 66F3A431FB5
	for <notmuch@notmuchmail.org>; Mon,  9 May 2011 05:10:13 -0700 (PDT)
Received: by qwb7 with SMTP id 7so3491337qwb.26
	for <notmuch@notmuchmail.org>; Mon, 09 May 2011 05:10:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=ZH2iBo1aQNLyzvyHifCYdPUVKYSxEzo6cOj8vswlMnQ=;
	b=n0zKWwl6Lrn8hzdfshWisvQ01OtEP/stmfOkUr22jw8xVvfSYgM8ocGFni068TOiLu
	HlA3owtJo+sKs72LWaR4TwwyP7BoxA643Lq00jmWhggmhVymB5H8oEUHXPWcAECKHilv
	mYHIAfsbgwyAcSVnr+yWqQRPDvdWevJLM/T00=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	b=bh/jE07OvmwuXed+WxDQLci1x5Qk7hgZRYEteHwOCH4uWXdKWDn7t3Lo1UsC5aIQi3
	KoN+5Lvy8FhV+Aacxb1kdafY3wKuo3mcPfBgV6TUxlBwKjX/sLnhfRhsl6qcq6tJluLs
	lEBheCcHr+4Otn1SuV5ZrkoidDiNuxe6cMT3Q=
MIME-Version: 1.0
Received: by 10.229.206.42 with SMTP id fs42mr4949670qcb.150.1304943012612;
	Mon, 09 May 2011 05:10:12 -0700 (PDT)
Sender: amdragon@gmail.com
Received: by 10.229.233.17 with HTTP; Mon, 9 May 2011 05:10:12 -0700 (PDT)
In-Reply-To: <1304924794-20380-1-git-send-email-anton@khirnov.net>
References: <1304924794-20380-1-git-send-email-anton@khirnov.net>
Date: Mon, 9 May 2011 08:10:12 -0400
X-Google-Sender-Auth: 0t7A61OTVq8j6LjWRpz5lv46Vps
Message-ID: <BANLkTin3BWD9uQ+8YwZtEd53LFMhVv8tAA@mail.gmail.com>
Subject: Re: [PATCH] python/thread: always return a string in
	get_subject/authors
From: Austin Clements <amdragon@mit.edu>
To: Anton Khirnov <anton@khirnov.net>
Content-Type: multipart/alternative; boundary=0016e68ee29db8097804a2d6b866
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2011 12:10:15 -0000

--0016e68ee29db8097804a2d6b866
Content-Type: text/plain; charset=ISO-8859-1

Your commit message is inconsistent with your change; is your intent to
return None or the empty string?  Also, could you modify your commit message
to say what "those" are?
On May 9, 2011 3:06 AM, "Anton Khirnov" <anton@khirnov.net> wrote:

--0016e68ee29db8097804a2d6b866
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<meta http-equiv=3D"content-type" content=3D"text/html; charset=3Dutf-8"><p=
>Your commit message is inconsistent with your change; is your intent to re=
turn None or the empty string? =A0Also, could you modify your commit messag=
e to say what &quot;those&quot; are?</p>

<div class=3D"gmail_quote">On May 9, 2011 3:06 AM, &quot;Anton Khirnov&quot=
; &lt;<a href=3D"mailto:anton@khirnov.net" target=3D"_blank">anton@khirnov.=
net</a>&gt; wrote:<br type=3D"attribution"></div>

--0016e68ee29db8097804a2d6b866--