Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 201F1429E21 for ; Wed, 11 Jan 2012 17:49:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ez7NOohHghyY for ; Wed, 11 Jan 2012 17:49:43 -0800 (PST) Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU [18.7.68.35]) by olra.theworths.org (Postfix) with ESMTP id 7D3A8431FB6 for ; Wed, 11 Jan 2012 17:49:43 -0800 (PST) X-AuditID: 12074423-b7f9c6d0000008c3-08-4f0e3c367b6a Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP id F6.61.02243.63C3E0F4; Wed, 11 Jan 2012 20:49:42 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q0C1nfUE005932; Wed, 11 Jan 2012 20:49:41 -0500 Received: from drake.mit.edu (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com [209.6.116.242]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0C1nd5U001507 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Wed, 11 Jan 2012 20:49:41 -0500 (EST) Received: from amthrax by drake.mit.edu with local (Exim 4.77) (envelope-from ) id 1Rl9nP-0007zy-4T; Wed, 11 Jan 2012 20:49:39 -0500 From: Austin Clements To: notmuch@notmuchmail.org Subject: [RFC PATCH 0/5] Convert show text format to new style Date: Wed, 11 Jan 2012 20:49:28 -0500 Message-Id: <1326332973-30225-1-git-send-email-amdragon@mit.edu> X-Mailer: git-send-email 1.7.7.3 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsUixCmqrWtmw+dv0HSSy+L6zZnMDowez1bd Yg5gjOKySUnNySxLLdK3S+DKuLn4MVPBAdaKA2ujGxi3sHQxcnJICJhI3DsxhxXCFpO4cG89 WxcjF4eQwD5GiVkL3rGDJIQENjBKfLmUDZG4zySxeektJghnPqPEralnwUaxCWhIbNu/nBHE FhGQlth5dzbQWA4OZgERiXczmUDCwgJ2Ek9ub2EDsVkEVCX2nF8CtplXwEHi5MrZzBBXKEic W32OfQIj7wJGhlWMsim5Vbq5iZk5xanJusXJiXl5qUW6Znq5mSV6qSmlmxhBIcDuoryD8c9B pUOMAhyMSjy8O/by+guxJpYVV+YeYpTkYFIS5f1uxecvxJeUn1KZkVicEV9UmpNafIhRgoNZ SYTXqQaonDclsbIqtSgfJiXNwaIkzquh9c5PSCA9sSQ1OzW1ILUIJivDwaEkwVtiDTRUsCg1 PbUiLTOnBCHNxMEJMpwHaHgGSA1vcUFibnFmOkT+FKOilDivO0hCACSRUZoH1wuL0VeM4kCv CPPmg1TxAOMbrvsV0GAmoMFb1vGADC5JREhJNTDq7sxVmBUZujX44uwqIcMUXoU1OT0s/t/d brGeremUvFC4x/Il3yrWArmrxfXOZilfNeTPfZ9WNqXMq1hKQkvHV0S75EpicMKPW8uic+6G 5AU8sFzKkzGhu7b2WoUBQ4qcteDsEp/Iqws1OZbfUXS9+NWE6YDnXuGm/49LdlRadWaWmjpm KLEUZyQaajEXFScCAKQ3blKsAgAA X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 01:49:45 -0000 I'm starting to convert the show formats to the new mime_node_t self-recursive style. Before I go through all of them, I wanted to get some feedback. Besides general feedback, I'm interested in knowing if this is a good way to structure the patches for review. Patches 1 through 3 just get requirements out of the way, but the actual conversion is done in two steps: patch 4 just moves the existing code into the new code structure without changing any of the logic and patch 5 simplifies the restructured code to actually benefit from the new structure. The hope is that patch 4 is easy to review even though it's big and that patch 5 makes the real (and interesting) changes obvious.