Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E6349429E25 for ; Thu, 26 May 2011 14:31:37 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id olh4c109db2p for ; Thu, 26 May 2011 14:31:37 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 88C38431FB6 for ; Thu, 26 May 2011 14:31:37 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 5E97929A4E7; Thu, 26 May 2011 14:31:36 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 0F0E125417E; Thu, 26 May 2011 14:31:36 -0700 (PDT) From: Carl Worth To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view. In-Reply-To: <87d3j5pxk5.fsf@gmail.com> References: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com> <1306361416-5019-4-git-send-email-dmitry.kurochkin@gmail.com> <87oc2qa07g.fsf@yoom.home.cworth.org> <87k4depfyj.fsf@gmail.com> <87lixu9z5b.fsf@yoom.home.cworth.org> <87hb8ipeb0.fsf@gmail.com> <87ipsy9sue.fsf@yoom.home.cworth.org> <87d3j5pxk5.fsf@gmail.com> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Thu, 26 May 2011 14:31:30 -0700 Message-ID: <87k4ddcfnx.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2011 21:31:38 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 26 May 2011 14:26:34 +0400, Dmitry Kurochkin wrote: > It is called indirectly. What is the best way to fix it? I imagine > that we can replace `isearch-range-invisible' function with another one, > which would call the fixed function if some special variable is set, or > if we are searching in a notmuch-show view. Otherwise it would call the > original function. I'm not sure what the best approach would be. I'd like to be a good "emacs citizen" but I don't know what the best way to do that is here. If we can predict what the first emacs release will be that contains the fix, then we could restrict our kludge here to older, unfixed emacs. That would help avoid some problems with "bad citizenship here". I'm willing to take whatever you this is best here. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk3exrIACgkQ6JDdNq8qSWjPHQCbByruXv7Gq0M9mvJ55m41c2pP aqMAoKkjTY8v0SH6Mu7rrPtGY8jbTUpR =1Uqs -----END PGP SIGNATURE----- --=-=-=--