From: Pieter Praet <pieter@praet.org>
To: Austin Clements <amdragon@mit.edu>, Mark Anderson <ma.skies@gmail.com>
Subject: Re: [PATCH] test:Improve test behaviors when --root is used
In-Reply-To: <BANLkTi=bXR+ors+YZH8yNkU7ZXEOvrXwDw@mail.gmail.com>
References: <87vcvrw91f.fsf@gmail.com>
	<BANLkTi=bXR+ors+YZH8yNkU7ZXEOvrXwDw@mail.gmail.com>
User-Agent: Notmuch/0.5-243-g5a76944 (http://notmuchmail.org) Emacs/23.1.50.1
	(x86_64-pc-linux-gnu)
Date: Tue, 28 Jun 2011 08:36:20 +0200
Message-ID: <874o3atqcb.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

On Mon, 27 Jun 2011 16:50:47 -0400, Austin Clements <amdragon@mit.edu> wrot=
e:
> This looks great (modulo one bug, below).  I've wanted to run the
> tests on tmpfs before, but was too lazy to actually fix the tests.
>=20
> Given how easy it is to accidentally use "..", I wonder if there's a
> way to force people to use $TEST_DIRECTORY?

Something like this? Mind you, my grep-fu is non-existent.

#+BEGIN_SRC sh
  dotdot=3D$(rgrep -nH -e "\.\.\/" . | grep -v -e "\$TEST_DIRECTORY")
  if [ -n "${dotdot}" ] ; then
    echo -e "Don't dot dot me! Use \$TEST_DIRECTORY as prefix instead.\n\nO=
ffending lines:\n ${dotdot}"
  fi
#+END_SRC

> On Mon, Jun 27, 2011 at 12:09 PM, Mark Anderson <ma.skies@gmail.com> wrot=
e:
> > --- a/test/symbol-hiding
> > +++ b/test/symbol-hiding
> > @@ -12,13 +12,13 @@ test_description=3D'exception symbol hiding'
> > =C2=A0. ./test-lib.sh
> >
> > =C2=A0run_test(){
> > - =C2=A0 =C2=A0result=3D$(LD_LIBRARY_PATH=3D../../lib ./symbol-test 2>&=
1)
> > + =C2=A0 =C2=A0result=3D$(LD_LIBRARY_PATH=3D$TEST_DIRECTORY/../../lib .=
/symbol-test 2>&1)
>=20
> Did you mean $TEST_DIRECTORY/../lib?
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Peace

--=20
Pieter