From: Thomas Jost <schnouki@schnouki.net>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH 2/4] emacs: Support a message-mode switch function in
	notmuch-mua
In-Reply-To: <877h4cc0bn.fsf@washington.ligo-wa.caltech.edu>
References: <1317643438-31272-1-git-send-email-schnouki@schnouki.net>
	<1317643438-31272-3-git-send-email-schnouki@schnouki.net>
	<877h4cc0bn.fsf@washington.ligo-wa.caltech.edu>
User-Agent: Notmuch/0.9_rc1-74-gdae3084 (http://notmuchmail.org)
	Emacs/24.0.90.1 (x86_64-unknown-linux-gnu)
Date: Tue, 11 Oct 2011 21:49:48 +0200
Message-ID: <8739eztijn.fsf@schnouki.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 10 Oct 2011 08:50:52 -0700, Jameson Graef Rollins <jrollins@finestr=
ucture.net> wrote:
> However, I find the customization variable a bit clunky.  Since I wasn't
> presented with any options in the customization, I didn't know what to
> put in.  I copy and pasted "switch-to-buffer-other-frame" into the
> customization field but that didn't work since I didn't protect the
> function name.  Finally I got it to work by putting in
> "'switch-to-buffer-other-frame" (with the initial "'").
>=20
> So I definitely love this feature, but can we make the customization
> work better so that it's easier for the user to figure out how to set
> it?

Heh, I had just tested it using "(setq ...)", not using M-x customize.
And yes, when using the customization interface it's not clear at all.
The problem is that the ":options" property of customizable variables
is only useful for hooks or alists, not for functions (but that isn't
documented anywhere, I had to dig in custom.el to find this).

So I think the best way to make that clearer and easier to figure out is
just to add more details in the docstring. I'll send a patch as a reply
to this message.

> Another question about this feature: how do you make the window
> (frame) go away after the email is sent?

I do this:
    (add-hook 'message-sent-hook 'delete-frame)

(added to the doc too).

Thanks for your review :)

=2D-=20
Thomas/Schnouki

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJOlJ3cAAoJEMPdciX+bh5IbUEH/iggjhul3tdzFHvzl3zfoVYt
E5TBrG5jzHCMSG7W1ar3Y0Lqf2W51ftN6dDc7ovfn5cEAcu1GXO+rB03AdwAqAQh
u69RAc5Ke5N7Uy8v3jPXMfzEmZ+iePzzZ9mp79lMF3naKQWUdbZBnTZWk5qn6hcD
Kj3xCNltsk70Y96AG9HSJbPklwdPfNmnwd4v3aZW7Q9Hi4xQm0A7YfyM07JJVMqo
qNrYPKfH0EwnbAk50N1L4CvuWTJzi6Cqgs8FnSDV5Zsxem9sNQcWIigU302uDFEj
2TlXxJNxodX31aOzzcGGXOROmw3C9mZfgGHila+VW6y8EEp+l9z1hevovq02Fv4=
=Svcj
-----END PGP SIGNATURE-----
--=-=-=--