From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: do not put quoted reply in primary selection
In-Reply-To: <87siuu95uy.fsf@servo.finestructure.net>
References: <1384689849-9388-1-git-send-email-markwalters1009@gmail.com>
	<87siuu95uy.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.16+175~g19e97d6 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Sun, 17 Nov 2013 21:42:40 +0200
Message-ID: <m2eh6e7r2n.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Sun, Nov 17 2013, Jameson Graef Rollins <jrollins@finestructure.net> wrote:

> On Sun, Nov 17 2013, Mark Walters <markwalters1009@gmail.com> wrote:
>> In current emacs (24.3) select-active-regions is set to t by
>> default. The reply insertion code sets the region to the quoted
>> message to make it easy to delete (kill-region or C-w). These two
>> things combine to put the quoted message in the primary selection.
>>
>> This is not what the user wanted and is a privacy risk (accidental
>> pasting of the quoted message). We can avoid some of the problems
>> by let-binding select-active-regions to nil. This fixes if the
>> primary selection was previously in a non-emacs window but not if
>> it was in an emacs window. To avoid the problem in the latter case
>> we deactivate mark.
>>
>> One key test (which fails under many simpler "fixes") is: open emacs
>> 24.3 with notmuch, open 2 windows (viewing different notmuch buffers),
>> highlight some text in one, and then reply to a message in the
>> other. In many of my earlier attempts to fix this big this test fails.
>
> I'm very happy to report that I reply to this message with an unpolluted
> paste buffer!  Kudos Mark!
>
>> Anyway, this is the best I can manage!
>
> Too modest for such an achievement.
>
> +10

This works for me too (and tests pass). 

I don't see how this could break thinks, So I think this is important
enough th be included in 0.17 

> jamie.

Tomi