Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CA1EF429E25 for ; Sun, 30 Oct 2011 17:04:51 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hez9z6x1chUV for ; Sun, 30 Oct 2011 17:04:51 -0700 (PDT) Received: from mail-gy0-f181.google.com (mail-gy0-f181.google.com [209.85.160.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 42551431FB6 for ; Sun, 30 Oct 2011 17:04:51 -0700 (PDT) Received: by gye5 with SMTP id 5so7420848gye.26 for ; Sun, 30 Oct 2011 17:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=8yomm/r+SBbB1tw+N0xiO3GBCdzz8Zs8bUeU1ZhA4O8=; b=GQVroj3EhS9drUCjvAqNqX0FW+1mPd9tSJHrfguAkR/W9weW7tLhgVq6wkhG75Np0T 3XcsLct7IU94GEI97vH1Xg9z6n7+bbppYaFFrxGrIMT/NU0ZvfjPoc6K80vU01ROj8pB 4/1fkCF0aDWrgFtE6JzG/tKKj9k05U2Pesavc= MIME-Version: 1.0 Received: by 10.68.30.129 with SMTP id s1mr19364065pbh.4.1320019489320; Sun, 30 Oct 2011 17:04:49 -0700 (PDT) Sender: amdragon@gmail.com Received: by 10.143.166.17 with HTTP; Sun, 30 Oct 2011 17:04:49 -0700 (PDT) In-Reply-To: <1319383133-11006-1-git-send-email-david@tethera.net> References: <1319383133-11006-1-git-send-email-david@tethera.net> Date: Sun, 30 Oct 2011 20:04:49 -0400 X-Google-Sender-Auth: c3hXiQaEXmXCNM32Z8lrtnuhySE Message-ID: Subject: Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. From: Austin Clements To: David Bremner Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: notmuch@notmuchmail.org, David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2011 00:04:51 -0000 LGTM. Code deduplication is always a good thing. "Internal interfaces for notmuch." doesn't seem like the best summary for util/error_util.h On Sun, Oct 23, 2011 at 11:18 AM, David Bremner wrote: > From: David Bremner > > We keep the lib/xutil.c version. As a consequence, also factor out > _internal_error and associated macros. =A0It might be overkill to make a > new file error_util.c for this, but _internal_error does not really > belong in database.cc.