From: Tomi Ollila <tomi.ollila@iki.fi>
To: Nils Dagsson Moskopp <nils@dieweltistgarnichtso.net>,
	notmuch@notmuchmail.org
Subject: Re: bug report: Emacs notmuch-mode fails attachments with spaces
In-Reply-To: <8761b9pu11.fsf@dieweltistgarnichtso.net>
References: <87twyurc78.fsf@dieweltistgarnichtso.net>
	<m24mqu455x.fsf@guru.guru-group.fi>
	<8761b9pu11.fsf@dieweltistgarnichtso.net>
User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 11 Feb 2015 14:28:03 +0200
Message-ID: <m24mqs63ak.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Tue, Feb 10 2015, Nils Dagsson Moskopp <nils@dieweltistgarnichtso.net> w=
rote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> On Mon, Feb 09 2015, Nils Dagsson Moskopp <nils@dieweltistgarnichtso.net=
> wrote:
>>
>>> Dear notmuch developers,
>>>
>>>
>>> I use notmuch-mode for GNU Emacs for managing my email.
>>>
>>> I think I have found a bug in notmuch-mode: If I do =E2=80=9C.-v=E2=80=
=9D on the line =E2=80=9C[
>>> 2015 _ Richtlinien.pdf: application/pdf ]=E2=80=9D, then notmuch will o=
pen three
>>> windows of zathura (the PDF viewer I use).
>>>
>>> It seems to me that someone here either forgot quoting or decided to
>>> split filenames on spaces. I suggest that =E2=80=9C2015 _ Richtlinien.p=
df:
>>> application/pdf=E2=80=9D should be quoted in notmuch-show-view-part.
>>>
>>> Note that saving attachment (=E2=80=9C.-s=E2=80=9D, notmuch-show-save-p=
art) generally
>>> works even if the attachment file names have spaces. In case it matters,
>>> I normally use the rc(1) shell in Debian <http://tobold.org/article/rc>.
>>
>> This code handles the saving and displaying in question (quick look hop i
>> am right :)
>>
>>    2282 (defun notmuch-show-save-part ()
>>    2283   "Save the MIME part containing point to a file."
>>    2284   (interactive)
>>    2285   (notmuch-show-apply-to-current-part-handle #'mm-save-part))
>>    2286=20
>>    2287 (defun notmuch-show-view-part ()
>>    2288   "View the MIME part containing point in an external viewer."
>>    2289   (interactive)
>>    2290   ;; Set mm-inlined-types to nil to force an external viewer
>>    2291   (let ((mm-inlined-types nil))
>>    2292     (notmuch-show-apply-to-current-part-handle #'mm-display-part=
)))
>>
>> SO, there is 2 options:
>>
>> 1) mm executes save part correctly but not display part
>
> It seems I cannot investigate this with my knowledge, as =E2=80=9CM-x
> find-function RET mm-display-part=E2=80=9D gives =E2=80=9CCan't find libr=
ary
> /usr/share/emacs/23.4/lisp/gnus/mm-decode.el=E2=80=9D. Any ideas?

you could download emacs-el package or something....

>
>> 2) there is (shell) wrapper program executing zathura which cannot handle
>>    arguments with spaces (there is plenty of examples of this!)
>>
>>
>> You could try to check how th external processes are executed by executi=
ng:
>>
>> strace -f -e trace=3Dprocess emacs -f notmuch
>>
>> (emacs on X is preferable in this case ;)
>
> Thank you for that suggestion. It seems that there does happen both some
> (wrong) escaping and splitting at spaces. I can see the following trace:
>
> --- snib ---
> execve("/usr/bin/zathura", ["/usr/bin/zathura", "/tmp/emm.23178ut2/2015\\=
", "_\\", "Richtlinien.pdf"] [/* 51 vars */]) =3D 0
> --- snab ---
>
> Somewhat unusually, it is preceeded by an invocation of the shell:
>
> --- sneb ---
> execve("/usr/bin/rc", ["/usr/bin/rc", "-c", "/usr/bin/zathura /tmp/emm.23=
178u"...], [/* 51 vars */] <unfinished ...>
> --- snob ---
>
> It seems to me that all of the following are true in this case:
>
> 1. Emacs executes the user's default shell to start zathura.

That's stupid! it should run /bin/sh.

I looked into emacs-23.1/lisp/gnus/mm-decode.el and while I could not
pinpoint the exact location where this shell command was invoked, I
found some similar code where emacs variable `shell-file-name` was used
(M-x describe-variable shell-file-name returns "/bin/zsh" for me).

So, you could just test by (setq shell-file-name "/bin/sh") (or=20
just M-x set-variable shell-file-name /bin/sh in live emacs) and then
test whether those pdf:s open right.

we cannot do much how (mm in) emacs escapes those variables (and why it
uses shell to execute that command line)...

Tomi

>
> 2. For this, Emacs escapes the filename.
>
> 3. Emacs applies the wrong escaping to the filename. Note that single
>    quotes are interoperable between shells, while backslashes are not.
>
> 4. The rc(1) shell splits on spaces, as it knows no backslash escaping.
>
> 5. The shell executes zathura with three arguments, all bogus filenames.
>
> I cannot pinpoint where all this is happening, but I would suggest to
> just execve() zathura with a single unescaped filename as its argument.
>
> Greetings,
> --=20
> Nils Dagsson Moskopp // erlehmann
> <http://dieweltistgarnichtso.net>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch