Date: Sun, 12 Jan 2014 17:06:19 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Jani Nikula <jani@nikula.org>
Subject: Re: [PATCH] notmuch: Add "maildir:" search option
Message-ID: <20140112160619.GM7572@laptop.programming.kicks-ass.net>
References: <20131112155637.GA16796@laptop.programming.kicks-ass.net>
	<8761ppurfz.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8761ppurfz.fsf@nikula.org>
User-Agent: Mutt/1.5.21 (2012-12-30)
Cc: notmuch@notmuchmail.org
Precedence: list

On Sun, Jan 12, 2014 at 05:53:52PM +0200, Jani Nikula wrote:
> On Tue, 12 Nov 2013, Peter Zijlstra <peterz@infradead.org> wrote:
> > Subject: notmuch: Add "maildir:" search option
> >
> > The current "folder:" search terms are near useless when you have
> > recursive folders, introduce a boolean "maildir:" search term to
> > exactly match the maildir folder.
> 
> Hi Peter -
> 
> Per some discussion on IRC about the usefulness of the current "folder:"
> prefix, I went ahead and sent patches to make "folder:" a boolean prefix
> [1]. It's not the same as your "maildir:" implementation, but I believe
> you could use it to achieve the things you want with that. In
> particular, my proposed "folder:" prefix is the literal path from
> maildir root, and does not make any assumptions about maildir - i.e. it
> requires the final cur/new too. (That can be useful for some mutt users
> who need the cur/new distinction.)
> 
> I am not opposed to adding another prefix like "maildir:" that does make
> assumptions on the mail storage and transformations on the path, but I
> do think it would be less important with the boolean "folder:" in place.

Right, sorry for disappearing; I failed to find time to finish the
patch.

I did actually modify it do loose the /new,/cur bits and I think I
addressed all other comments, including the file removal part.

Where I got 'stuck' was writing test cases.

Anyway, I'll try and have a look at the recent notmuch.git and see if it
does what I'd like it to.

Thanks for getting back to me.

~ Peter