Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 2E2F8431FC3
	for <notmuch@notmuchmail.org>; Thu, 16 May 2013 04:16:11 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.3
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id WKo6nTtS8uAk for <notmuch@notmuchmail.org>;
	Thu, 16 May 2013 04:16:03 -0700 (PDT)
Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id B52A1431FC2
	for <notmuch@notmuchmail.org>; Thu, 16 May 2013 04:16:03 -0700 (PDT)
Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
	by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4GBFxWC017468;
	Thu, 16 May 2013 08:16:00 -0300
Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
	([156.34.82.78] helo=zancas.localnet)
	by tesseract.cs.unb.ca with esmtpsa
	(TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1UcwAB-0004ZS-Dn; Thu, 16 May 2013 08:15:59 -0300
Received: from bremner by zancas.localnet with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1UcwA5-0002TC-Ma; Thu, 16 May 2013 08:15:53 -0300
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] build: fix out-of-tree builds
In-Reply-To: <874ne49pcm.fsf@nikula.org>
References: <1368615519-25977-1-git-send-email-jani@nikula.org>
	<87ehd8fdzg.fsf@zancas.localnet> <874ne49pcm.fsf@nikula.org>
User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 16 May 2013 08:15:53 -0300
Message-ID: <87hai3dvkm.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_bar: -
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 16 May 2013 11:16:11 -0000

Jani Nikula <jani@nikula.org> writes:

> On Wed, 15 May 2013, David Bremner <david@tethera.net> wrote:
>> Jani Nikula <jani@nikula.org> writes:
>>>  # List all subdirectories here. Each contains its own Makefile.local
>>> -subdirs := compat completion emacs lib man parse-time-string
>>> -subdirs += performance-test util test
>>> +subdirs = compat completion emacs lib man parse-time-string performance-test util test
>>
>> Is this a functional change or a cosmetic one?
>
> Functional. All of it seems to be required for out-of-tree builds (*) to
> work. I'm afraid I've forgotten exactly why both := and += make it fail
> (I wrote the patch a few months ago).
>

Still I guess it deserves a comment so we don't break it again?

d