Return-Path: <cceleri@cs.stanford.edu>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id E622B431FC3
	for <notmuch@notmuchmail.org>; Mon,  1 Dec 2014 09:02:15 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.3
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id bGX68a2NkfGs for <notmuch@notmuchmail.org>;
	Mon,  1 Dec 2014 09:02:09 -0800 (PST)
Received: from smtp2.cs.Stanford.EDU (smtp2.cs.stanford.edu [171.64.64.26])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 05D98431FC0
	for <notmuch@notmuchmail.org>; Mon,  1 Dec 2014 09:02:08 -0800 (PST)
Received: from tor-exit.de ([195.37.190.67]:44480 helo=Jane.lan)
	by smtp2.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128)
	(Exim 4.80.1) (envelope-from <cceleri@cs.stanford.edu>)
	id 1XvUMN-0004Ym-4l; Mon, 01 Dec 2014 09:02:06 -0800
From: Charles Celerier <cceleri@cs.stanford.edu>
To: David Edmondson <dme@dme.org>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2] emacs: Added "is:<tag>" style completion
	to	notmuch-read-query.
In-Reply-To: <cunh9xfg9i2.fsf@gargravarr.hh.sledj.net>
References: <1417219835-92141-1-git-send-email-cceleri@cs.stanford.edu>
	<1417279197-90877-1-git-send-email-cceleri@cs.stanford.edu>
	<cunh9xfg9i2.fsf@gargravarr.hh.sledj.net>
User-Agent: Notmuch/0.18.1+208~g93eda7e (http://notmuchmail.org) Emacs/24.4.1
	(x86_64-apple-darwin14.0.0)
Date: Mon, 01 Dec 2014 12:01:52 -0500
Message-ID: <m2wq6bs3r3.fsf@Jane.lan>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-Scan-Signature: 1a99e790efc5595ebc7b409aae77a077
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2014 17:02:16 -0000

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Can the variables in the varlist depend on the definition of variables
that precede them in the list? I believe I tried your suggestion, but
quickly gave up as Emacs gave me an error claiming that all-tags was
void.

charles

David Edmondson <dme@dme.org> writes:

> On Sat, Nov 29 2014, Charles Celerier wrote:
>> The notmuch-search-terms man page states that "tag:<tag>" is equivalent
>> to "is:<tag>". Completion for "is:<tag>" style searches is now supported
>> in the Emacs interface.
>>
>> Signed-off-by: Charles Celerier <cceleri@cs.stanford.edu>
>> ---
>>  emacs/notmuch.el | 11 +++++++----
>>  1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
>> index 218486a..d29499c 100644
>> --- a/emacs/notmuch.el
>> +++ b/emacs/notmuch.el
>> @@ -856,12 +856,15 @@ See `notmuch-tag' for information on the format of=
 TAG-CHANGES."
>>=20=20
>>  PROMPT is the string to prompt with."
>>    (lexical-let
>> +    (( all-tags
>> +        (mapcar (lambda (tag) (notmuch-escape-boolean-term tag))
>> +                (process-lines notmuch-command "search" "--output=3Dtag=
s" "*"))))
>> +  (let
>
> I think that David's suggestion was that you would have only one `let'
> form, so something like:
>
>  (lexical-let*
>    ((all-tags (mapcar ...))
>     (completions (append ...))
>     (keymap (copy-keymap ...))
>     (current-query ...))
>      ...)
>
>>        ((completions
>>  	(append (list "folder:" "path:" "thread:" "id:" "date:" "from:" "to:"
>>  		      "subject:" "attachment:")
>> -		(mapcar (lambda (tag)
>> -			  (concat "tag:" (notmuch-escape-boolean-term tag)))
>> -			(process-lines notmuch-command "search" "--output=3Dtags" "*")))))
>> +		(mapcar (lambda (tag) (concat "tag:" tag)) all-tags)
>> +		(mapcar (lambda (tag) (concat "is:" tag)) all-tags))))
>>      (let ((keymap (copy-keymap minibuffer-local-map))
>>  	  (current-query (case major-mode
>>  			   (notmuch-search-mode (notmuch-search-get-query))
>> @@ -884,7 +887,7 @@ PROMPT is the string to prompt with."
>>        (define-key keymap (kbd "TAB") 'minibuffer-complete)
>>        (let ((history-delete-duplicates t))
>>  	(read-from-minibuffer prompt nil keymap nil
>> -			      'notmuch-search-history current-query nil)))))
>> +			      'notmuch-search-history current-query nil))))))
>>=20=20
>>  (defun notmuch-search-get-query ()
>>    "Return the current query in this search buffer"
>> --=20
>> 2.1.2
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2

iQEcBAEBAgAGBQJUfJ8BAAoJEOjk698fDjuAZMcH/j3DCPbML4Mg4F3SvsDhSDmj
zVQ+m2jiOXGkrpgxf9zJugwutt5PlULMmQkOKB8gxzAAvLFO3WC89zeEm453z12Z
jlKpHJY/DnMF3Y34Sj9UYbUXdIWZEzMqJRv7F6UrWL32xcnOIbV45v1oikUNiRdE
ivhYjU5CiSa8HU1TrbKxidkr3SXfBcD0A6re48zEcCD32Wi86at6a0ZRPANEa5Xa
tGqiyt2AClbIUvJ3o7ozPeVFCFuVi+R3jy1fOM4ynKz2AWCpjEpvMyIDMSztkT9K
xvqpw81x0no9a8Rhq3GkxxxKJBHPKYmoKGVOTxXN4vSEQFsyNP3tyhSgnAyZdus=
=A8/Y
-----END PGP SIGNATURE-----
--=-=-=--