From: Moritz Ulrich <moritz@tarn-vedra.de>
To: notmuch@notmuchmail.org
Subject: `notmuch-escape-boolean-term': Broken for non-ascii characters
User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Mon, 11 Aug 2014 22:38:16 +0200
Message-ID: <874mxiu5hj.fsf@tarn-vedra.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Hello,

I recently adopted notmuch as my primary way to read mail, so thank you
for this great tool!

Unfortunately, I ran into a problem of the Emacs side of the project
when used in a non-ascii environment:

Having a tag named 'uni-k=C3=B6ln', the tag:-completion doesn't work.

This is caused by `notmuch-escape-boolean-term' errornously escaping the
above string:

(notmuch-escape-boolean-term "uni-k=C3=B6ln") =3D> "\"uni-k=C3=B6ln\""

This is caused by `string-match' with the following errornously matching
my tag:

(string-match "[^!#-'*-~]" "uni-k=C3=B6ln") =3D> 5
(string-match "[^!#-'*-~]" "uni-koln") =3D> nil

I'm not exactly sure how to tackle this - the Regexp was crafted to match
(, ), " if I understand it correct. A simple way would be just adding
more characters as a sort-of whitelist. A nicer solution would be
converting it from [^...] to [...] to explicitly mark letters that needs
to be escaped.

Cheers,
Moritz Ulrich

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJT6Sm9AAoJEKnhzHnsv6Qyp/MP/2AxFLNbuE8OazOaqDuNWR//
fegXTAYkLHYYsd+pzLQgFuqC2mF4vh0hFM3cWJJTyoASzUBEM239nj1jLuloDSVv
YcGBo+HBO4cqir9ly2UTLH9SkcEghx5zScfjVIygjZWwIFZRCjsfyXD5rK74Cv38
4pi/LTEfX4CulQv3LwAGGZtN0ez+GP1fS7nWDNxUVO+tREJYg4S2sinSOmBPKaua
lgkWEAXTJDj12FUijkR9RHcE5TviVXaW2n4mf833hvvbhHslaRic7fbmX56Sny40
UaLkeJtoTF61yfoL2gazo5LjqQbBrrOzvGa5xHZhwtEnFNY9qlu8lxtdonhr63eK
esVCaA+Q2D1lhw4JEPXgy1NcPHEp5x3CP/Dno8eXzK5+s2f85oFVX4cZREm+STc1
7MWxSWOBshn8+QtStK4a4RIGgLnq5XoH8QBWi/Vh1ug30DBRsMfnXbLbiz6DrWf6
koV3DnWcaVxbVQKXaSl/4DGzfbr1C4DO4S5nnjM40Aa1zfaUz64qxATKff0ZsIqN
yN/Fll2SXJEdSRTH3F1sFrxWbVl7/5Taf9xyOsggjF5EPGXR9Ykxks9K+sTT3f1e
Bp3EM4UZyyPepwTUU/KfgufC6yL6/GxEtx4KSuAlfvBoDCQpJyQ6OYyUjwruGIoH
3K5sXP5xLAQVX4FyMxVe
=9eCy
-----END PGP SIGNATURE-----
--=-=-=--