Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 92F29429E35 for ; Mon, 28 Nov 2011 06:24:31 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gjzvQGFvJy83 for ; Mon, 28 Nov 2011 06:24:30 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id D5367429E2F for ; Mon, 28 Nov 2011 06:24:23 -0800 (PST) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 465D42E50DD1; Mon, 28 Nov 2011 06:24:23 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (dyn-pupin-171-227.dyn.columbia.edu [128.59.171.227]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 68A372E5069F; Mon, 28 Nov 2011 06:24:20 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 5B1E3B8F; Mon, 28 Nov 2011 06:24:19 -0800 (PST) From: Jameson Graef Rollins To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show In-Reply-To: <1322259811-10834-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1322259811-10834-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.10~rc1+25~g719d650 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 28 Nov 2011 06:24:19 -0800 Message-ID: <87lir0xr3g.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2011 14:24:32 -0000 --=-=-= On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin wrote: > -(defun notmuch-show-get-header (header) > +(defun notmuch-show-get-header (header &optional props) > "Return the named header of the current message, if any." > - (plist-get (notmuch-show-get-prop :headers) header)) > + (plist-get (notmuch-show-get-prop :headers props) header)) Hey, Dmitry. It looks like the new plist-get call is assuming props is defined, but it looks like it's only optional in the argument list. Wouldn't the function fail if the props argument is not supplied? jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJO05mTAAoJEO00zqvie6q8Ya8P/0cZORADkMMeM0KFqlKZ0JSm mRA3sb7wXs2GzsC0bGs6iErLHBt+yNe11dAk9lL9OssWkP/C1VQdOzGYqfiKmUqR EP88ScwCIbn277sQaFObbRBzaW+5JP9JlDKEe6Rx6OT1jn3XTrsg8qvWQ6N5Xy9g Ms73SuR1xD3gISt/dsXLCiKmHTNr3va53eSubedY5p0WHpHM8Lcf2Zo6jE09H2UW 9RSfJ4rGptoXVyUbFAcpMyLko3lKhhwnfqlk5KaFQSpV+tLm4pwI+MuTPz+IZOt+ QxF35KPJlya4ji2AndAekdp054+O9ajJ0DpJTfrhhmtqnyBHGLmm3Jvz8BgEmN57 0gUv81NMK+1kOBSnMagwnRQfqmMlmzQPBXnQH45fJVlUzuAEBujPzNPn70FXBz2g 3BJA99jn/2VVcf4ZEwJ5UxUTBXopNKQv7LU0hfB23bEe3TWtNR4dMCekdh/uwYak tsGobOanHer74xHEwAvDKtcYx2JCfdwPFYfyZ3u5+TrNDIXy6UiYvnmtfDBsHrML gNIk54t0Sl7b6dZasueQYrBWfb3N6YSyKdNtAuw028CTyXKGDc4AYvW0bOzSJbm9 W5OnaSTBsHPMGAJvNh5zR9rKu94eoBrI6n/xon/r6fPI75Chlx72+KnTrXPvnKts 9SGyMuCrGNoSrtaG8BxY =ysjn -----END PGP SIGNATURE----- --=-=-=--