Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E6CE1431FBC for ; Mon, 15 Feb 2010 18:13:05 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.857 X-Spam-Level: X-Spam-Status: No, score=-1.857 tagged_above=-999 required=5 tests=[AWL=0.742, BAYES_00=-2.599] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OxTtfCU+hnJU for ; Mon, 15 Feb 2010 18:13:04 -0800 (PST) Received: from clegg.madduck.net (clegg.madduck.net [193.242.105.96]) by olra.theworths.org (Postfix) with ESMTP id 84431431FAE for ; Mon, 15 Feb 2010 18:13:04 -0800 (PST) Received: from lapse.rw.madduck.net (unknown [IPv6:2404:130:0:1000:20a:e4ff:fe30:4316]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "lapse.rw.madduck.net", Issuer "CAcert Class 3 Root" (verified OK)) by clegg.madduck.net (postfix) with ESMTPS id AD5E21D4099; Tue, 16 Feb 2010 03:12:53 +0100 (CET) Received: by lapse.rw.madduck.net (Postfix, from userid 1000) id 3D94AB1E; Tue, 16 Feb 2010 15:12:50 +1300 (NZDT) Date: Tue, 16 Feb 2010 15:12:50 +1300 From: martin f krafft To: Stewart Smith Message-ID: <20100216021250.GB21780@lapse.rw.madduck.net> Mail-Followup-To: Stewart Smith , Tim Stoakes , notmuch@notmuchmail.org References: <9cce5525b093b87fe74d427954ffad89@localhost> <87d43b2oif.fsf@yoom.home.cworth.org> <9bfdedddeab9c58cd45d8d448323d0fc@localhost> <87skc23327.fsf@yoom.home.cworth.org> <4b0eef22.JwxdgTGElffx149F%michiel@michielbuddingh.net> <87ws1bjpmm.fsf@yoom.home.cworth.org> <878wdfkhcl.fsf@aegir.org.uk> <20100210031339.GH16686@mail.rocksoft.com> <20100215081331.GD22402@flamingspork.com> <20100216015856.GG22402@flamingspork.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-ripemd160; protocol="application/pgp-signature"; boundary="ftEhullJWpWg/VHq" Content-Disposition: inline In-Reply-To: <20100216015856.GG22402@flamingspork.com> X-Motto: Keep the good times rollin' X-OS: Debian GNU/Linux squeeze/sid kernel 2.6.32-1-686 i686 X-Spamtrap: madduck.bogus@madduck.net X-Subliminal-Message: debian/rules! User-Agent: Mutt/1.5.20 (2009-06-14) X-Virus-Scanned: clamav-milter 0.95.3 at clegg X-Virus-Status: Clean Cc: notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH] notmuch: Respect maildir message flags X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 02:13:06 -0000 --ftEhullJWpWg/VHq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable also sprach Stewart Smith [2010.02.16.1458 +1300= ]: > + case 'R': /* replied */ > + notmuch_message_add_tag (message, "answered"); > + break; 'r' means replied, not 'answered'. > + case 'T': /* trashed */ > + notmuch_message_add_tag (message, "deleted"); > + break; Same. trashed and deleted are not the same thing. I don't want to get into an argument over this, because I think this already exposes a problem: you are putting into global namespace something not everyone might want, or agree with. Why not use 'maildirflags::replied' instead? People can always map that to something in the global namespace. --=20 martin | http://madduck.net/ | http://two.sentenc.es/ =20 "geld ist das brecheisen der macht." - friedrich nietzsche =20 spamtraps: madduck.bogus@madduck.net --ftEhullJWpWg/VHq Content-Type: application/pgp-signature; name="digital_signature_gpg.asc" Content-Description: Digital signature (see http://martin-krafft.net/gpg/) Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEAREDAAYFAkt5/xwACgkQIgvIgzMMSnWm7QCgluXOhObiPTeKqr/dAmMtMjSj lJsAn2++4aof8HnnOk19xbpTWh5uTEPr =boFw -----END PGP SIGNATURE----- --ftEhullJWpWg/VHq--