From: David Bremner <david@tethera.net>
To: "W. Trevor King" <wking@tremily.us>, Austin Clements <amdragon@mit.edu>
Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section
In-Reply-To: <20140922190022.GO20827@odin.tremily.us>
References: <1411400615-20934-1-git-send-email-amdragon@mit.edu>
	<20140922165954.GI20827@odin.tremily.us>
	<20140922185050.GB7970@csail.mit.edu>
	<20140922190022.GO20827@odin.tremily.us>
User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 24 Sep 2014 20:09:27 +0200
Message-ID: <87iokc28mg.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Cc: notmuch@notmuchmail.org
Precedence: list

"W. Trevor King" <wking@tremily.us> writes:


> Ah, I thought the implicit flush/commit was just in our code.  Since
> it's also in the underlying Xapian close, then this patch looks pretty
> good to me.  I'd mention Xapian's explicit close in the notmuch.
h
> message.  Xapain's docs say [1]:
>
>   For a WritableDatabase, if a transaction is active it will be
>   aborted, while if no transaction is active commit() will be
>   implicitly called.

I'm not sure what you're asking for here by "explicit close". Isn't what
you quote a restatement of 

+ * If the caller is currently in an atomic section (there was a
+ * notmuch_database_begin_atomic without a matching
+ * notmuch_database_end_atomic), this will abort the atomic
section,
+ * discarding any modifications made in the atomic section.

in terms of underyling Xapian mechanics?


P.S. Other than whatever this doc question is, the patch looks ok to me.