From: Jani Nikula <jani@nikula.org>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: on deleting messages
In-Reply-To: <87vcoaywyu.fsf@servo.finestructure.net>
References: <87vcoaywyu.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.11+76~g1de742d (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Tue, 17 Jan 2012 22:21:18 +0200
Message-ID: <877h0qkrlt.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> Now that Austin's excellent tag exclusion patch set [0] has been pushed,
> the question remains if we want to support any delete-handling key
> bindings in emacs.
> 
> Based on the show-mode improvements I recently sent [1], the following
> patch set implements thread and message delete keys.
> 
> This is the last I'm going to comment on this issue.  If we don't want
> to support this, we should put together something on the wiki that
> states we don't want to support it and that users should just bind it
> themselves (with a nice explanation how), so that we can try to reduce
> the number of future patches on the issue.
> 
> Given the number of patches we've had on this issue, though, it's clear
> that a lot of people expect this functionality, so we may want to
> seriously consider supporting it.  Given Austin's tag exclusion stuff,
> and the fact that "deleted" tags are excluded by default, we now have
> the functionality that Carl originally wanted to see, so it's not so
> unreasonable to support this functionality anymore.

I think it's reasonable to consider having key bindings (or other
special handling) for pretty much *any* tags that are special to
notmuch: inbox, unread, draft, flagged, etc. (An exhaustive list should
be documented somewhere.)

Looking at the source and history, I have to admit there has been
intent, and code, to have support for "deleted" tag. See for example
TODO or [1].

And I agree there has been demand for this.

I say let's have this.

But make it clear that "deleted" is just a tag; that the messages aren't
going away, not by notmuch anyway.


BR,
Jani.

[1] commit 2c262042ac174d7bc96d6035ab9c88bd0abe7f35