Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3B61C431FBC for ; Fri, 24 Jan 2014 06:58:15 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0NGaicBSEUNo for ; Fri, 24 Jan 2014 06:58:10 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 6723D431FB6 for ; Fri, 24 Jan 2014 06:58:10 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 201801000B3; Fri, 24 Jan 2014 16:58:03 +0200 (EET) From: Tomi Ollila To: Mark Walters , David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] test: make test_emacs call post-command-hook In-Reply-To: <87d2jizjlu.fsf@qmul.ac.uk> References: <1387064676-15508-6-git-send-email-markwalters1009@gmail.com> <1390354365-12311-1-git-send-email-david@tethera.net> <87d2jizjlu.fsf@qmul.ac.uk> User-Agent: Notmuch/0.17+41~g8e7fabf (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 14:58:15 -0000 On Thu, Jan 23 2014, Mark Walters wrote: >> What do you think about this alternate version? it allows >> notmuch-test-progn to have the same syntax as progn. It seems about >> the same level of complexity to me; fwiw I prefer the let over the >> dolist/setq. > > This looks much nicer: a macro is definitely the right way to do this. > > I might be inclined to replace the let... by a prog1 but would be happy > either way on that. prog1! definitely ! :D > > Best wishes > > Mark > Tomi >> +(defmacro notmuch-test-progn (&rest body) >> + (cons 'progn >> + (mapcar >> + (lambda (x) `(let ((ret ,x)) >> + (notmuch-post-command) >> + ret)) >> + body)))