From: Jani Nikula <jani@nikula.org>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: Xapian-quoting based batch-tagging.
In-Reply-To: <1356464567-21779-1-git-send-email-david@tethera.net>
References: <1356464567-21779-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.14+235~gdaf492b (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Thu, 03 Jan 2013 20:59:36 +0100
Message-ID: <87ip7eghqv.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 25 Dec 2012, david@tethera.net wrote:
> This is an alternative version of 
>
>      id:1356313183-9266-1-git-send-email-david@tethera.net
>
> batch tagging patches rebased on top of 
>
>      id:1356415076-5692-1-git-send-email-amdragon@mit.edu

I didn't go through this quite as thoroughly as the previous versions,
but the series LGTM. I like how this simplifies things. In the future,
I'd like us to support xapian quoting also in the tag changes, for
consistency.

BR,
Jani.



>
> This mainly consisted of removing 
>
>      [Patch v9 04/17] notmuch-tag: factor out double quoting routine
>      (superceded by one of Austin's patches)
>
>      [Patch v9 05/17] util/string-util: add a new string tokenized function
>      [Patch v9 06/17] unhex_and_quote: new function to quote hex-decoded queries
>      [Patch v9 07/17] notmuch-restore: move query handling for batch	
>      (uneeded if query is passed verbatim to xapian)
>
>      I also removed two tests, since they are about how we handle
>      quoting:
>
>      [Patch v9 13/17] test/tagging: add test for compound queries with batch tagging
>      [Patch v9 17/17] test/tagging: add test for handling of parenthesized	tag queries.
>
> A few small fixes were needed to the tests, and a fair amount of
> changes to the notmuch-tag man page.
>
> Diffstat (against Austin's series) is as follows
>
>  man/man1/notmuch-tag.1 |   99 ++++++++++++++++++++-
>  notmuch-tag.c          |  169 ++++++++++++++++++++----------------
>  tag-util.c             |   87 +++++++++++++++++--
>  tag-util.h             |   15 ++++
>  test/tagging           |  195 ++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 480 insertions(+), 85 deletions(-)
>
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch