DomainKey-Signature: a=rsa-sha1; c=nofws; d=sspaeth.de; h=from:to:subject
	:in-reply-to:references:date:message-id:mime-version:
	content-type; q=dns; s=sspaeth.de; b=kS93x1u2UoMUDWDA63rTx4YjcQ2
	xQXuDUevADTlGwjgni5T35YnGqGSmaAhiN1TgS/YwR5T4V84SXVgfn8BaK9q7e/i
	qVQbcm0GJ0DovBPnxfwl3Z5zYVf4BqQXQF/ieVAYO2r9txvr6/Sne7VCYkLwaDIU
	EobNZGA7xKlNrDkU=
From: Sebastian Spaeth <sebastian@sspaeth.de>
To: Ali Polatel <polatel@gmail.com>, notmuch@notmuchmail.org
Subject: Re: Concerns regarding some library functions
In-Reply-To: <871uv2unfd.fsf@gmail.com>
References: <871uv2unfd.fsf@gmail.com>
User-Agent: Notmuch/0.7-19-gee4579a (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Wed, 28 Sep 2011 17:42:01 +0200
Message-ID: <87ipocoera.fsf@SSpaeth.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 27 Sep 2011 16:25:58 +0300, Ali Polatel wrote:
> The two functions I've mentioned above are
> notmuch_database_find_message() and
> notmuch_database_find_message_by_filename().
>=20
> The problem with their design is NULL return may both mean an error
> condition and "message not found". However, we already have a similar
> function which does not have such a flaw, namely notmuch_database_add_mes=
sage().

Yes, this is because NULL used to mean message not found and NULL means
error was tacked on later (because cworth did not expect that xapian
would actually throw errors that often (such as database modified and
whatnot). So the meaning of NULL is, ahhem, suboptimal...

ERROR or really not there? There are mails from me, commenting on
that. I would welcome receiving back a notmuch_status_t value and have a
separate notmuch_message_t parameter which receives the actual message.

Sebastian

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk6DQEkACgkQVYX1jMgnoGL3IQCfRiU9//SCkK1nfbE0/cZRotKZ
iJYAnA5GSWb3tmvY/ulL7OcF7lhePC0B
=GzPU
-----END PGP SIGNATURE-----
--=-=-=--