Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A5AF4431FBD for ; Sat, 28 Jan 2012 04:55:25 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V8R8DhrAM4QK for ; Sat, 28 Jan 2012 04:55:25 -0800 (PST) Received: from mail-pz0-f53.google.com (mail-pz0-f53.google.com [209.85.210.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id DEDFE431FBC for ; Sat, 28 Jan 2012 04:55:24 -0800 (PST) Received: by dadv6 with SMTP id v6so2865465dad.26 for ; Sat, 28 Jan 2012 04:55:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.115.174 with SMTP id jp14mr23046424pbb.42.1327755322955; Sat, 28 Jan 2012 04:55:22 -0800 (PST) Received: by 10.68.236.137 with HTTP; Sat, 28 Jan 2012 04:55:22 -0800 (PST) Received: by 10.68.236.137 with HTTP; Sat, 28 Jan 2012 04:55:22 -0800 (PST) In-Reply-To: <87y5ssxam7.fsf@zancas.localnet> References: <87k44uprvy.fsf@praet.org> <1326532638-22068-1-git-send-email-pieter@praet.org> <87y5ssxam7.fsf@zancas.localnet> Date: Sat, 28 Jan 2012 14:55:22 +0200 Message-ID: Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." From: Jani Nikula To: David Bremner Content-Type: multipart/alternative; boundary=047d7b1120d15f97cb04b7962004 Cc: Notmuch Mail , Pieter Praet X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2012 12:55:25 -0000 --047d7b1120d15f97cb04b7962004 Content-Type: text/plain; charset=UTF-8 On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > > Less code, same results, without sacrificing readability. > > > > This looks OK, although the re-indenting makes these kind of changes > painful to review (not that I'm suggesting we should re-indent, just > some random complaining). Sometimes someone (Dmitry?) sent patches that separated a small functional change, and the big non-functional indentation change it caused, separately. Would you prefer (or tolerate ;) that style? > > d > > --047d7b1120d15f97cb04b7962004 Content-Type: text/html; charset=UTF-8


On Jan 28, 2012 2:41 PM, "David Bremner" <david@tethera.net> wrote:
>
> On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Less code, same results, without sacrificing readability.
> >
>
> This looks OK, although the re-indenting makes these kind of changes
> painful to review (not that I'm suggesting we should re-indent, just
> some random complaining).

Sometimes someone (Dmitry?) sent patches that separated a small functional change, and the big non-functional indentation change it caused, separately. Would you prefer (or tolerate ;) that style?

>
> d
>
>

--047d7b1120d15f97cb04b7962004--