Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C83E9431FD0 for ; Wed, 21 Dec 2011 10:27:26 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.7 X-Spam-Level: * X-Spam-Status: No, score=1.7 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iz4uoxXDMf-7 for ; Wed, 21 Dec 2011 10:27:26 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 48E47431FB6 for ; Wed, 21 Dec 2011 10:27:26 -0800 (PST) Received: by wibhq2 with SMTP id hq2so2691290wib.26 for ; Wed, 21 Dec 2011 10:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=Tx6t6tmp86PfbwMcQdvLpd2ZBa4Mt6LMRkkzkH48t1k=; b=Pw4GMoH+3c5AgOykHL/B8ybKCD64Jslee5CY0pXwTagUzFwoBmjePNce+Q2uqMc1C+ TgNHf5VKdRGIkg/se/Ey5SRwxWhX9RFByla4MeBg+MKHb8TPiBPJWhwtqNzFM4aB5GBE Y1h81pcX3BvmKqYi15cmgmOHW0wjt6IZv+ZGM= Received: by 10.181.13.162 with SMTP id ez2mr16549645wid.17.1324492044993; Wed, 21 Dec 2011 10:27:24 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id em4sm6726800wbb.20.2011.12.21.10.27.23 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 21 Dec 2011 10:27:23 -0800 (PST) From: Dmitry Kurochkin To: Thomas Jost Subject: Re: [PATCH] test: add tests for `notmuch-hello-refresh-hook' In-Reply-To: <1324473189-8622-1-git-send-email-schnouki@schnouki.net> References: <87iplawvx5.fsf@gmail.com> <1324473189-8622-1-git-send-email-schnouki@schnouki.net> User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 21 Dec 2011 22:26:40 +0400 Message-ID: <871urxwzkv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2011 18:27:26 -0000 Hi Thomas. I think all hook count tests must be consistent. We should either add hook counters in test-lib.el (like it is already done for `notmuch-hello-mode-hook') or use lambdas in individual test cases (like you did in the patch). I believe the former approach is better (that is why I used it in the first place :)). So I sent patches [1] that add general hook counter to test-lib.el and `notmuch-hello-mode-hook' tests that use it. Regards, Dmitry [1] id:"1324491506-1134-1-git-send-email-dmitry.kurochkin@gmail.com"