To: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH v2 05/10] install: check for non-SysV version (Solaris
	support) 
In-Reply-To: Your message of "Tue, 06 Nov 2012 18:51:43 +0200."
	<m2vcdiznc0.fsf@guru.guru-group.fi> 
Date: Wed, 07 Nov 2012 22:22:26 -0800
Message-ID: <23236.1352355746@foo.net>
From: Blake Jones <blakej@foo.net>
Cc: notmuch@notmuchmail.org
Precedence: list

> > diff --git a/vim/Makefile b/vim/Makefile
> > index f17bebf..7ceba7a 100644
> > --- a/vim/Makefile
> > +++ b/vim/Makefile
> > @@ -5,8 +5,6 @@ files = plugin/notmuch.vim \
> >  prefix = $(HOME)/.vim
> >  destdir = $(prefix)/plugin
> >  
> > -INSTALL = install -D -m644
> > -
> >  all: help
> >  
> >  help:
> > @@ -17,7 +15,7 @@ help:
> >  	@echo "    make symlink     - create symlinks in ~/.vim (useful for dev
> elopment)"
> >  
> >  install:
> > -	@for x in $(files); do $(INSTALL) $(CURDIR)/$$x $(prefix)/$$x; done
> > +	@for x in $(files); do $(INSTALL) -D -m644 $(CURDIR)/$$x $(prefix)/$$x;
>  done
> >  
> > -link symlink: INSTALL = ln -fs
> >  link symlink: install
> > +	@for x in $(files); do ln -fs $(CURDIR)/$$x $(prefix)/$$x; done
> > -- 
> 
> Here you'd need to remove the 'install' dependency as it would first
> do it and then overwriting the results with dependency.

Good catch, thanks; that's what I'll do.  I also noticed a couple other
things in this file -- I need to "include ../Makefile.config" to get the
definition of $INSTALL, and $destdir isn't used in that Makefile.

Blake