From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
	notmuch mailing list <notmuch@notmuchmail.org>
Subject: Re: test suite crash with TERM=dumb
In-Reply-To: <87obgibu5x.fsf@zancas.localnet>
References: <87obgibu5x.fsf@zancas.localnet>
User-Agent: Notmuch/0.15+5~g6f527c2 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
Date: Mon, 21 Jan 2013 16:44:27 +0200
Message-ID: <m2wqv6ppdg.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Mon, Jan 21 2013, David Bremner <david@tethera.net> wrote:

> In 0.15 (or current master) try running 
>
>   % TERM=dump make test
>
> At least for me and the Debian build daemons, this causes the run to end
> with
>
>   PASS   Show message: json, utf-8
>   FATAL: Unexpected exit with code 1
>   make: *** [test] Error 124
>
> This is much worse than a test failure since it causes the build to exit
> with non-zero status.
>
> I have temporarily disabled running the test suite in the debian
> packaging, but this is obviously not a good permanent solution.
>
> Apparently the problem is on the line 
>
>  TERM=$ORIGINAL_TERM dtach -n "$TEST_TMPDIR/emacs-dtach-socket.$$" 
>
> It would be easy to hardcode the TERM for dtach, but I'm not sure if
> there is some advantage to testing with the user's actual term? Also, I
> guess we'd have to be careful the chosen terminal type is portable.

For user it only matters when/if one wants to attach to the dtach'd
terminal (i.e. rarely). Then if the terminal chosen is knows subset of
the control sequences any of the terminals users might use then it is not
much of a problem -- the terminal just doesn't work optimally, display
colors or something.

In your tests you could just run `TERM=xterm make test` (and forget the
issue >;)

> d

Tomi