Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6951E431FD0 for ; Fri, 30 Dec 2011 17:30:33 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "Date" X-Spam-Flag: NO X-Spam-Score: -0.367 X-Spam-Level: X-Spam-Status: No, score=-0.367 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, INVALID_DATE=0.432, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tn6HxpQjo9Ls for ; Fri, 30 Dec 2011 17:30:33 -0800 (PST) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 0C9AD431FB6 for ; Fri, 30 Dec 2011 17:30:33 -0800 (PST) Received: by qcha6 with SMTP id a6so11060464qch.26 for ; Fri, 30 Dec 2011 17:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=content-type:mime-version:content-transfer-encoding:from:to :references:in-reply-to:date:message-id:subject:date; bh=BUg4j47+YHQI89FIfziZRly32Z97ezvoFRydmKWtNrM=; b=qOkmUCQ3PrnXAYNZcwvyR4LzAg6p+eDllaoFdlheUS/v96Nr0YnLgNNvrEks22Aq6f 2zwenD/DUrRGq8f3QKFHyM+AMn7Qo0xjy4u3TgqIaqaqfhwvuVj+Roe4D/IFZXOdc/6f 6MaQmYS5HxiTxh4QOHiU8LimLeEf1FQKv8Q7o= Received: by 10.229.136.83 with SMTP id q19mr15144451qct.145.1325295032376; Fri, 30 Dec 2011 17:30:32 -0800 (PST) Received: from localhost (201-1-35-143.dsl.telesp.net.br. [201.1.35.143]) by mx.google.com with ESMTPS id el7sm75917603qab.16.2011.12.30.17.30.30 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Dec 2011 17:30:31 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Kazuo Teramoto To: Patrick Totzke , notmuch@notmuchmail.org, David Bremner References: <877h1e6r9d.fsf@zancas.localnet> <1325282290-29565-1-git-send-email-kaz.rag@gmail.com> <20111231011647.24112.70437@brick.lan> In-Reply-To: <20111231011647.24112.70437@brick.lan> Date: Sat, 31 Dec 2011 01:30:28 -0000 Message-ID: <20111231013028.14545.79903@sophie> Subject: Re: [PATCH 0/2] Multiples calls of g_mime_init Date: Fri, 30 Dec 2011 23:30:28 -0200 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Dec 2011 01:30:33 -0000 On 2011-12-30T23:16:47, Patrick Totzke wrote: >It seeminly doesn't break things either and I'm all in favour of doing >things right=E2=84=A2. And talking about doing things right, we probably need to call g_mime_shutdown() too, one for every time we call g_mime_init(). I will send a patch after I do some more tests. >On a related note: It also doesn't fix the recent segfaults of the bindings >that occur when you try to write to a locked database. >cf "id:4eddf2b1.4288980a.0b74.5557@mx.google.com" > This still hit me. If I remember right when I did a test what is happening is that the binding is trying to close the db, so we need a check if the db is opened before trying to close it.